dungeon_object_emulator_preview.cc

Go to the documentation of this file.

#include "app/gui/widgets/dungeon_object_emulator_preview.h"
 
#include <cstdio>
#include <cstring>
 
#include "app/editor/agent/agent_ui_theme.h"
#include "app/emu/render/emulator_render_service.h"
#include "app/emu/render/render_context.h"
#include "app/gfx/backend/irenderer.h"
#include "app/gfx/resource/arena.h"
#include "app/gfx/types/snes_palette.h"
#include "app/gui/automation/widget_auto_register.h"
#include "app/platform/window.h"
#include "zelda3/dungeon/object_drawer.h"
#include "zelda3/dungeon/room.h"
#include "zelda3/dungeon/room_object.h"
 
using namespace yaze::editor;
 
namespace {
 
// Convert 8BPP linear tile data to 4BPP SNES planar format
// Input: 64 bytes per tile (1 byte per pixel, linear row-major order)
// Output: 32 bytes per tile (4 bitplanes interleaved per SNES 4BPP format)
std::vector<uint8_t> ConvertLinear8bppToPlanar4bpp(
    const std::vector<uint8_t>& linear_data) {
  size_t num_tiles = linear_data.size() / 64;  // 64 bytes per 8x8 tile
  std::vector<uint8_t> planar_data(num_tiles * 32);  // 32 bytes per tile
 
  for (size_t tile = 0; tile < num_tiles; ++tile) {
    const uint8_t* src = linear_data.data() + tile * 64;
    uint8_t* dst = planar_data.data() + tile * 32;
 
    for (int row = 0; row < 8; ++row) {
      uint8_t bp0 = 0, bp1 = 0, bp2 = 0, bp3 = 0;
 
      for (int col = 0; col < 8; ++col) {
        uint8_t pixel = src[row * 8 + col] & 0x0F;  // Low 4 bits only
        int bit = 7 - col;  // MSB first
 
        bp0 |= ((pixel >> 0) & 1) << bit;
        bp1 |= ((pixel >> 1) & 1) << bit;
        bp2 |= ((pixel >> 2) & 1) << bit;
        bp3 |= ((pixel >> 3) & 1) << bit;
      }
 
      // SNES 4BPP interleaving: bp0,bp1 for rows 0-7 first, then bp2,bp3
      dst[row * 2] = bp0;
      dst[row * 2 + 1] = bp1;
      dst[16 + row * 2] = bp2;
      dst[16 + row * 2 + 1] = bp3;
    }
  }
 
  return planar_data;
}
 
// Convert SNES LoROM address to PC (file) offset
// ALTTP uses LoROM mapping:
// - Banks $00-$3F: Address $8000-$FFFF maps to ROM
// - Each bank contributes 32KB ($8000 bytes) of ROM data
// - PC = (bank & 0x7F) * 0x8000 + (addr - 0x8000)
// Takes a 24-bit SNES address (e.g., 0x018200 = bank $01, addr $8200)
uint32_t SnesToPc(uint32_t snes_addr) {
  uint8_t bank = (snes_addr >> 16) & 0xFF;
  uint16_t addr = snes_addr & 0xFFFF;
 
  // LoROM: banks $00-$3F map to ROM ($8000-$FFFF only)
  // Each bank = 32KB of ROM, so multiply bank by 0x8000
  // Formula: PC = (bank & 0x7F) * 0x8000 + (addr - 0x8000)
  if (addr >= 0x8000) {
    return (bank & 0x7F) * 0x8000 + (addr - 0x8000);
  }
  // For addresses below $8000, return as-is (WRAM/hardware regs)
  return snes_addr;
}
 
}  // namespace
 
namespace yaze {
namespace gui {
 
DungeonObjectEmulatorPreview::DungeonObjectEmulatorPreview() {
  // Defer SNES initialization until actually needed to reduce startup memory
}
 
DungeonObjectEmulatorPreview::~DungeonObjectEmulatorPreview() {
  // if (object_texture_) {
  //   renderer_->DestroyTexture(object_texture_);
  // }
}
 
void DungeonObjectEmulatorPreview::Initialize(
    gfx::IRenderer* renderer, Rom* rom, zelda3::GameData* game_data,
    emu::render::EmulatorRenderService* render_service) {
  renderer_ = renderer;
  rom_ = rom;
  game_data_ = game_data;
  render_service_ = render_service;
  // Defer SNES initialization until EnsureInitialized() is called
  // This avoids a ~2MB ROM copy during startup
  // object_texture_ = renderer_->CreateTexture(256, 256);
}
 
void DungeonObjectEmulatorPreview::EnsureInitialized() {
  if (initialized_) return;
  if (!rom_ || !rom_->is_loaded()) return;
 
  snes_instance_ = std::make_unique<emu::Snes>();
  // Use const reference to avoid copying the ROM data
  const std::vector<uint8_t>& rom_data = rom_->vector();
  snes_instance_->Init(rom_data);
 
  // Create texture for rendering output
  if (renderer_ && !object_texture_) {
    object_texture_ = renderer_->CreateTexture(256, 256);
  }
 
  initialized_ = true;
}
 
void DungeonObjectEmulatorPreview::Render() {
  if (!show_window_) return;
 
  const auto& theme = AgentUI::GetTheme();
 
  // No window creation - embedded in parent
  {
    AutoWidgetScope scope("DungeonEditor/EmulatorPreview");
 
    // ROM status indicator at top
    if (rom_ && rom_->is_loaded()) {
      ImGui::TextColored(theme.status_success, "ROM: Loaded");
      ImGui::SameLine();
      ImGui::TextDisabled("Ready to render objects");
    } else {
      ImGui::TextColored(theme.status_error, "ROM: Not loaded");
      ImGui::SameLine();
      ImGui::TextDisabled("Load a ROM to use this tool");
    }
 
    ImGui::Separator();
 
    // Vertical layout for narrow panels
    RenderControls();
 
    AgentUI::VerticalSpacing(8);
    ImGui::Separator();
 
    // Preview image with border
    AgentUI::PushPanelStyle();
    ImGui::BeginChild("PreviewRegion", ImVec2(0, 280), true,
                      ImGuiWindowFlags_NoScrollbar);
    ImGui::TextColored(theme.text_info, "Preview");
    ImGui::Separator();
    if (object_texture_) {
      ImVec2 available = ImGui::GetContentRegionAvail();
      float scale = std::min(available.x / 256.0f, available.y / 256.0f);
      ImVec2 preview_size(256 * scale, 256 * scale);
 
      // Center the preview
      float offset_x = (available.x - preview_size.x) * 0.5f;
      if (offset_x > 0) ImGui::SetCursorPosX(ImGui::GetCursorPosX() + offset_x);
 
      ImGui::Image((ImTextureID)object_texture_, preview_size);
    } else {
      ImGui::TextColored(theme.text_warning_yellow, "No texture available");
      ImGui::TextWrapped("Click 'Render Object' to generate a preview");
    }
    ImGui::EndChild();
    AgentUI::PopPanelStyle();
 
    AgentUI::VerticalSpacing(8);
 
    // Status panel
    RenderStatusPanel();
 
    // Help text at bottom
    AgentUI::VerticalSpacing(8);
    ImGui::PushStyleColor(ImGuiCol_ChildBg, theme.box_bg_dark);
    ImGui::BeginChild("HelpText", ImVec2(0, 0), true);
    ImGui::TextColored(theme.text_info, "How it works:");
    ImGui::Separator();
    ImGui::TextWrapped(
        "This tool uses the SNES emulator to render objects by executing the "
        "game's native drawing routines from bank $01. This provides accurate "
        "previews of how objects will appear in-game.");
    ImGui::EndChild();
    ImGui::PopStyleColor();
  }
 
  // Render object browser if visible
  if (show_browser_) {
    RenderObjectBrowser();
  }
}
 
void DungeonObjectEmulatorPreview::RenderControls() {
  const auto& theme = AgentUI::GetTheme();
 
  // Object ID section with name lookup
  ImGui::TextColored(theme.text_info, "Object Selection");
  ImGui::Separator();
 
  // Object ID input with hex display
  AutoInputInt("Object ID", &object_id_, 1, 10,
               ImGuiInputTextFlags_CharsHexadecimal);
  ImGui::SameLine();
  ImGui::TextColored(theme.text_secondary_gray, "($%03X)", object_id_);
 
  // Display object name and type
  const char* name = GetObjectName(object_id_);
  int type = GetObjectType(object_id_);
 
  ImGui::PushStyleColor(ImGuiCol_ChildBg, theme.panel_bg_darker);
  ImGui::BeginChild("ObjectInfo", ImVec2(0, 60), true);
  ImGui::TextColored(theme.accent_color, "Name:");
  ImGui::SameLine();
  ImGui::TextWrapped("%s", name);
  ImGui::TextColored(theme.accent_color, "Type:");
  ImGui::SameLine();
  ImGui::Text("%d", type);
  ImGui::EndChild();
  ImGui::PopStyleColor();
 
  AgentUI::VerticalSpacing(4);
 
  // Quick select dropdown
  if (ImGui::BeginCombo("Quick Select", "Choose preset...")) {
    for (const auto& preset : kQuickPresets) {
      if (ImGui::Selectable(preset.name, object_id_ == preset.id)) {
        object_id_ = preset.id;
      }
      if (object_id_ == preset.id) {
        ImGui::SetItemDefaultFocus();
      }
    }
    ImGui::EndCombo();
  }
 
  AgentUI::VerticalSpacing(4);
 
  // Browse button for full object list
  if (AgentUI::StyledButton("Browse All Objects...", theme.accent_color,
                            ImVec2(-1, 0))) {
    show_browser_ = !show_browser_;
  }
 
  AgentUI::VerticalSpacing(8);
  ImGui::Separator();
 
  // Position and size controls
  ImGui::TextColored(theme.text_info, "Position & Size");
  ImGui::Separator();
 
  AutoSliderInt("X Position", &object_x_, 0, 63);
  AutoSliderInt("Y Position", &object_y_, 0, 63);
  AutoSliderInt("Size", &object_size_, 0, 15);
  ImGui::SameLine();
  ImGui::TextDisabled("(?)");
  if (ImGui::IsItemHovered()) {
    ImGui::SetTooltip(
        "Size parameter for scalable objects.\nMany objects ignore this value.");
  }
 
  AgentUI::VerticalSpacing(8);
  ImGui::Separator();
 
  // Room context
  ImGui::TextColored(theme.text_info, "Rendering Context");
  ImGui::Separator();
 
  AutoInputInt("Room ID", &room_id_, 1, 10);
  ImGui::SameLine();
  ImGui::TextDisabled("(?)");
  if (ImGui::IsItemHovered()) {
    ImGui::SetTooltip("Room ID for graphics and palette context");
  }
 
  AgentUI::VerticalSpacing(8);
 
  // Render mode selector
  ImGui::TextColored(theme.text_info, "Render Mode");
  int mode = static_cast<int>(render_mode_);
  if (ImGui::RadioButton("Static (ObjectDrawer)", &mode, 0)) {
    render_mode_ = RenderMode::kStatic;
    static_render_dirty_ = true;
  }
  ImGui::SameLine();
  ImGui::TextDisabled("(?)");
  if (ImGui::IsItemHovered()) {
    ImGui::SetTooltip(
        "Uses ObjectDrawer to render objects.\n"
        "This is the reliable method that matches the main canvas.");
  }
  if (ImGui::RadioButton("Emulator (Experimental)", &mode, 1)) {
    render_mode_ = RenderMode::kEmulator;
  }
  ImGui::SameLine();
  ImGui::TextDisabled("(?)");
  if (ImGui::IsItemHovered()) {
    ImGui::SetTooltip(
        "Attempts to run game drawing handlers via CPU emulation.\n"
        "EXPERIMENTAL: Handlers require full game state to work.\n"
        "Most objects will time out without rendering.");
  }
 
  AgentUI::VerticalSpacing(12);
 
  // Render button - large and prominent
  if (AgentUI::StyledButton("Render Object", theme.status_success,
                            ImVec2(-1, 40))) {
    if (render_mode_ == RenderMode::kStatic) {
      TriggerStaticRender();
    } else {
      TriggerEmulatedRender();
    }
  }
}
 
void DungeonObjectEmulatorPreview::TriggerEmulatedRender() {
  if (!rom_ || !rom_->is_loaded()) {
    last_error_ = "ROM not loaded";
    return;
  }
 
  // Use shared render service if available (set to emulated mode)
  if (render_service_ && render_service_->IsReady()) {
    // Temporarily switch to emulated mode
    auto prev_mode = render_service_->GetRenderMode();
    render_service_->SetRenderMode(emu::render::RenderMode::kEmulated);
 
    emu::render::RenderRequest request;
    request.type = emu::render::RenderTargetType::kDungeonObject;
    request.entity_id = object_id_;
    request.x = object_x_;
    request.y = object_y_;
    request.size = object_size_;
    request.room_id = room_id_;
    request.output_width = 256;
    request.output_height = 256;
 
    auto result = render_service_->Render(request);
 
    // Restore previous mode
    render_service_->SetRenderMode(prev_mode);
 
    if (result.ok() && result->success) {
      last_cycle_count_ = result->cycles_executed;
      // Update texture with rendered pixels
      if (!object_texture_) {
        object_texture_ = renderer_->CreateTexture(256, 256);
      }
      void* pixels = nullptr;
      int pitch = 0;
      if (renderer_->LockTexture(object_texture_, nullptr, &pixels, &pitch)) {
        memcpy(pixels, result->rgba_pixels.data(), result->rgba_pixels.size());
        renderer_->UnlockTexture(object_texture_);
      }
      printf("[SERVICE-EMU] Rendered object $%04X via EmulatorRenderService\n",
             object_id_);
      return;
    } else {
      printf("[SERVICE-EMU] Emulated render failed, falling back to legacy: %s\n",
             result.ok() ? result->error.c_str()
                         : std::string(result.status().message()).c_str());
    }
  }
 
  // Legacy emulated rendering path
  // Lazy initialize the SNES emulator on first use
  EnsureInitialized();
  if (!snes_instance_) {
    last_error_ = "Failed to initialize SNES emulator";
    return;
  }
 
  last_error_.clear();
  last_cycle_count_ = 0;
 
  // 1. Reset and configure the SNES state
  snes_instance_->Reset(true);
  auto& cpu = snes_instance_->cpu();
  auto& ppu = snes_instance_->ppu();
  auto& memory = snes_instance_->memory();
 
  // 2. Load room context (graphics, palettes)
  zelda3::Room default_room = zelda3::LoadRoomFromRom(rom_, room_id_);
  default_room.SetGameData(game_data_);  // Ensure room has access to GameData
 
  // 3. Load palette into CGRAM (full 120 colors including sprite aux)
  if (!game_data_) {
    last_error_ = "GameData not available";
    return;
  }
  auto dungeon_main_pal_group = game_data_->palette_groups.dungeon_main;
 
  // Validate and clamp palette ID
  int palette_id = default_room.palette;
  if (palette_id < 0 ||
      palette_id >= static_cast<int>(dungeon_main_pal_group.size())) {
    printf("[EMU] Warning: Room palette %d out of bounds, using palette 0\n",
           palette_id);
    palette_id = 0;
  }
 
  // Load dungeon main palette (palettes 0-5, indices 0-89)
  auto base_palette = dungeon_main_pal_group[palette_id];
  for (size_t i = 0; i < base_palette.size() && i < 90; ++i) {
    ppu.cgram[i] = base_palette[i].snes();
  }
 
  // Load sprite auxiliary palettes (palettes 6-7, indices 90-119)
  // ROM $0D:D308 = Sprite aux palette group (SNES address, needs LoROM conversion)
  constexpr uint32_t kSpriteAuxPaletteSnes = 0x0DD308;  // SNES: bank $0D, addr $D308
  const uint32_t kSpriteAuxPalettePc = SnesToPc(kSpriteAuxPaletteSnes);  // PC: $65308
  for (int i = 0; i < 30; ++i) {
    uint32_t addr = kSpriteAuxPalettePc + i * 2;
    if (addr + 1 < rom_->size()) {
      uint16_t snes_color = rom_->data()[addr] | (rom_->data()[addr + 1] << 8);
      ppu.cgram[90 + i] = snes_color;
    }
  }
  printf("[EMU] Loaded full palette: 90 dungeon + 30 sprite aux = 120 colors\n");
 
  // 4. Load graphics into VRAM
  // Graphics buffer contains 8BPP linear data, but VRAM needs 4BPP planar
  default_room.LoadRoomGraphics(default_room.blockset);
  default_room.CopyRoomGraphicsToBuffer();
  const auto& gfx_buffer = default_room.get_gfx_buffer();
 
  // Convert 8BPP linear to 4BPP SNES planar format using local function
  std::vector<uint8_t> linear_data(gfx_buffer.begin(), gfx_buffer.end());
  auto planar_data = ConvertLinear8bppToPlanar4bpp(linear_data);
 
  // Copy 4BPP planar data to VRAM (32 bytes = 16 words per tile)
  for (size_t i = 0; i < planar_data.size() / 2 && i < 0x8000; ++i) {
    ppu.vram[i] = planar_data[i * 2] | (planar_data[i * 2 + 1] << 8);
  }
 
  printf("[EMU] Converted %zu bytes (8BPP linear) to %zu bytes (4BPP planar)\n",
         gfx_buffer.size(), planar_data.size());
 
  // 5. CRITICAL: Initialize tilemap buffers in WRAM
  // Game uses $7E:2000 for BG1 tilemap buffer, $7E:4000 for BG2
  for (uint32_t i = 0; i < 0x2000; i++) {
    snes_instance_->Write(0x7E2000 + i, 0x00);  // BG1 tilemap buffer
    snes_instance_->Write(0x7E4000 + i, 0x00);  // BG2 tilemap buffer
  }
 
  // 5b. CRITICAL: Initialize zero-page tilemap pointers ($BF-$DD)
  // Handlers use indirect long addressing STA [$BF],Y which requires
  // 24-bit pointers to be set up. These are NOT stored in ROM - they're
  // initialized dynamically by the game's room loading code.
  // We manually set them to point to BG1 tilemap buffer rows.
  //
  // BG1 tilemap buffer is at $7E:2000, 64×64 entries (each 2 bytes)
  // Each row = 64 × 2 = 128 bytes = $80 apart
  // The 11 pointers at $BF, $C2, $C5... point to different row offsets
  constexpr uint8_t kPointerZeroPageAddrs[] = {0xBF, 0xC2, 0xC5, 0xC8, 0xCB,
                                                0xCE, 0xD1, 0xD4, 0xD7, 0xDA,
                                                0xDD};
 
  // Base address for BG1 tilemap in WRAM: $7E2000
  // Each pointer points to a different row offset for the drawing handlers
  constexpr uint32_t kBG1TilemapBase = 0x7E2000;
  constexpr uint32_t kRowStride = 0x80;  // 64 tiles × 2 bytes per tile
 
  for (int i = 0; i < 11; ++i) {
    uint32_t wram_addr = kBG1TilemapBase + (i * kRowStride);
    uint8_t lo = wram_addr & 0xFF;
    uint8_t mid = (wram_addr >> 8) & 0xFF;
    uint8_t hi = (wram_addr >> 16) & 0xFF;
 
    uint8_t zp_addr = kPointerZeroPageAddrs[i];
    // Write 24-bit pointer to direct page in WRAM
    snes_instance_->Write(0x7E0000 | zp_addr, lo);
    snes_instance_->Write(0x7E0000 | (zp_addr + 1), mid);
    snes_instance_->Write(0x7E0000 | (zp_addr + 2), hi);
 
    printf("[EMU] Tilemap ptr $%02X = $%06X\n", zp_addr, wram_addr);
  }
 
  // 6. Setup PPU registers for dungeon rendering
  snes_instance_->Write(0x002105, 0x09);  // BG Mode 1 (4bpp for BG1/2)
  snes_instance_->Write(0x002107, 0x40);  // BG1 tilemap at VRAM $4000 (32x32)
  snes_instance_->Write(0x002108, 0x48);  // BG2 tilemap at VRAM $4800 (32x32)
  snes_instance_->Write(0x002109, 0x00);  // BG1 chr data at VRAM $0000
  snes_instance_->Write(0x00210A, 0x00);  // BG2 chr data at VRAM $0000
  snes_instance_->Write(0x00212C, 0x03);  // Enable BG1+BG2 on main screen
  snes_instance_->Write(0x002100, 0x0F);  // Screen display on, full brightness
 
  // 6b. CRITICAL: Mock APU I/O registers to prevent infinite handshake loop
  // The APU handshake at $00:8891 waits for SPC700 to respond with $BBAA
  // APU has SEPARATE read/write latches:
  //   - Write() goes to in_ports_ (CPU→SPC direction)
  //   - Read() returns from out_ports_ (SPC→CPU direction)
  // We must set out_ports_ directly for the CPU to see the mock values!
  auto& apu = snes_instance_->apu();
  apu.out_ports_[0] = 0xAA;  // APU I/O port 0 - ready signal (SPC→CPU)
  apu.out_ports_[1] = 0xBB;  // APU I/O port 1 - ready signal (SPC→CPU)
  apu.out_ports_[2] = 0x00;  // APU I/O port 2
  apu.out_ports_[3] = 0x00;  // APU I/O port 3
  printf("[EMU] APU mock: out_ports_[0]=$AA, out_ports_[1]=$BB (SPC→CPU)\n");
 
  // 7. Setup WRAM variables for drawing context
  snes_instance_->Write(0x7E00AF, room_id_ & 0xFF);
  snes_instance_->Write(0x7E049C, 0x00);
  snes_instance_->Write(0x7E049E, 0x00);
 
  // 7b. Object drawing parameters in zero-page
  // These are expected by the drawing handlers
  snes_instance_->Write(0x7E0004, GetObjectType(object_id_));  // Object type
  uint16_t y_offset = object_y_ * 0x80;  // Tilemap Y offset
  snes_instance_->Write(0x7E0008, y_offset & 0xFF);
  snes_instance_->Write(0x7E0009, (y_offset >> 8) & 0xFF);
  snes_instance_->Write(0x7E00B2, object_size_);  // Size X parameter
  snes_instance_->Write(0x7E00B4, object_size_);  // Size Y parameter
 
  // Room state variables
  snes_instance_->Write(0x7E00A0, room_id_ & 0xFF);
  snes_instance_->Write(0x7E00A1, (room_id_ >> 8) & 0xFF);
  printf("[EMU] Object params: type=%d, y_offset=$%04X, size=%d\n",
         GetObjectType(object_id_), y_offset, object_size_);
 
  // 8. Create object and encode to bytes
  zelda3::RoomObject obj(object_id_, object_x_, object_y_, object_size_, 0);
  auto bytes = obj.EncodeObjectToBytes();
 
  const uint32_t object_data_addr = 0x7E1000;
  snes_instance_->Write(object_data_addr, bytes.b1);
  snes_instance_->Write(object_data_addr + 1, bytes.b2);
  snes_instance_->Write(object_data_addr + 2, bytes.b3);
  snes_instance_->Write(object_data_addr + 3, 0xFF);  // Terminator
  snes_instance_->Write(object_data_addr + 4, 0xFF);
 
  // 9. Setup object pointer in WRAM
  snes_instance_->Write(0x7E00B7, object_data_addr & 0xFF);
  snes_instance_->Write(0x7E00B8, (object_data_addr >> 8) & 0xFF);
  snes_instance_->Write(0x7E00B9, (object_data_addr >> 16) & 0xFF);
 
  // 10. Lookup the object's drawing handler using TWO-TABLE system
  // Table 1: Data offset table (points into RoomDrawObjectData)
  // Table 2: Handler routine table (address of drawing routine)
  // All tables are in bank $01, need LoROM conversion to PC offset
  auto rom_data = rom_->data();
  uint32_t data_table_snes = 0;
  uint32_t handler_table_snes = 0;
 
  if (object_id_ < 0x100) {
    // Type 1 objects: $01:8000 (data), $01:8200 (handler)
    data_table_snes = 0x018000 + (object_id_ * 2);
    handler_table_snes = 0x018200 + (object_id_ * 2);
  } else if (object_id_ < 0x200) {
    // Type 2 objects: $01:8370 (data), $01:8470 (handler)
    data_table_snes = 0x018370 + ((object_id_ - 0x100) * 2);
    handler_table_snes = 0x018470 + ((object_id_ - 0x100) * 2);
  } else {
    // Type 3 objects: $01:84F0 (data), $01:85F0 (handler)
    data_table_snes = 0x0184F0 + ((object_id_ - 0x200) * 2);
    handler_table_snes = 0x0185F0 + ((object_id_ - 0x200) * 2);
  }
 
  // Convert SNES addresses to PC offsets for ROM reads
  uint32_t data_table_pc = SnesToPc(data_table_snes);
  uint32_t handler_table_pc = SnesToPc(handler_table_snes);
 
  uint16_t data_offset = 0;
  uint16_t handler_addr = 0;
 
  if (data_table_pc + 1 < rom_->size() && handler_table_pc + 1 < rom_->size()) {
    data_offset = rom_data[data_table_pc] | (rom_data[data_table_pc + 1] << 8);
    handler_addr = rom_data[handler_table_pc] | (rom_data[handler_table_pc + 1] << 8);
  } else {
    last_error_ = "Object ID out of bounds for handler lookup";
    return;
  }
 
  if (handler_addr == 0x0000) {
    char buf[256];
    snprintf(buf, sizeof(buf), "Object $%04X has no drawing routine",
             object_id_);
    last_error_ = buf;
    return;
  }
 
  printf("[EMU] Two-table lookup (PC: $%04X, $%04X): data_offset=$%04X, handler=$%04X\n",
         data_table_pc, handler_table_pc, data_offset, handler_addr);
 
  // 11. Setup CPU state with correct register values
  cpu.PB = 0x01;     // Program bank (handlers in bank $01)
  cpu.DB = 0x7E;     // Data bank (WRAM for tilemap writes)
  cpu.D = 0x0000;    // Direct page at $0000
  cpu.SetSP(0x01FF); // Stack pointer
  cpu.status = 0x30; // M=1, X=1 (8-bit A/X/Y mode)
  cpu.E = 0;         // Native 65816 mode, not emulation mode
 
  // X = data offset (into RoomDrawObjectData at bank $00:9B52)
  cpu.X = data_offset;
  // Y = tilemap buffer offset (position in tilemap)
  cpu.Y = (object_y_ * 0x80) + (object_x_ * 2);
 
  // 12. Setup return trap with STP instruction
  // Use STP ($DB) instead of RTL for more reliable handler completion detection
  // Place STP at $01:FF00 (unused area in bank $01)
  const uint16_t trap_addr = 0xFF00;
  snes_instance_->Write(0x01FF00, 0xDB);  // STP opcode - stops CPU
 
  // Push return address for RTL (3 bytes: bank, high, low-1)
  // RTL adds 1 to the address, so push trap_addr - 1
  uint16_t sp = cpu.SP();
  snes_instance_->Write(0x010000 | sp--, 0x01);                   // Bank byte
  snes_instance_->Write(0x010000 | sp--, (trap_addr - 1) >> 8);   // High
  snes_instance_->Write(0x010000 | sp--, (trap_addr - 1) & 0xFF); // Low
  cpu.SetSP(sp);
 
  // Jump to handler address in bank $01
  cpu.PC = handler_addr;
 
  printf("[EMU] Rendering object $%04X at (%d,%d), handler=$%04X\n", object_id_,
         object_x_, object_y_, handler_addr);
  printf("[EMU] X=data_offset=$%04X, Y=tilemap_pos=$%04X, PB:PC=$%02X:%04X\n",
         cpu.X, cpu.Y, cpu.PB, cpu.PC);
  printf("[EMU] STP trap at $01:%04X for return detection\n", trap_addr);
 
  // 13. Run emulator with STP detection
  // Check for STP opcode BEFORE executing to catch the return trap
  int max_opcodes = 100000;
  int opcodes = 0;
  while (opcodes < max_opcodes) {
    // Check for STP trap - handler has returned
    uint32_t current_addr = (cpu.PB << 16) | cpu.PC;
    uint8_t current_opcode = snes_instance_->Read(current_addr);
    if (current_opcode == 0xDB) {
      printf("[EMU] STP trap hit at $%02X:%04X - handler completed!\n",
             cpu.PB, cpu.PC);
      break;
    }
 
    // CRITICAL: Keep refreshing APU out_ports_ to counteract CatchUpApu()
    // The APU code runs during Read() calls and may overwrite our mock values
    // Refresh every 100 opcodes to ensure the handshake check passes
    if ((opcodes & 0x3F) == 0) {  // Every 64 opcodes
      apu.out_ports_[0] = 0xAA;
      apu.out_ports_[1] = 0xBB;
    }
 
    // Detect APU handshake loop at $00:8891 and force skip it
    // The loop reads $2140, compares to $AA, branches if not equal
    if (cpu.PB == 0x00 && cpu.PC == 0x8891) {
      // We're stuck in APU handshake - this shouldn't happen with the mock
      // but if it does, force the check to pass by setting accumulator
      static int apu_loop_count = 0;
      if (++apu_loop_count > 100) {
        printf("[EMU] WARNING: Stuck in APU loop at $00:8891, forcing skip\n");
        // Skip past the loop by advancing PC (typical pattern is ~6 bytes)
        cpu.PC = 0x8898;  // Approximate address after the handshake loop
        apu_loop_count = 0;
      }
    }
 
    cpu.RunOpcode();
    opcodes++;
 
    // Debug: Sample WRAM after 10k opcodes to see if handler is writing
    if (opcodes == 10000) {
      printf("[EMU] WRAM $7E2000 after 10k opcodes: ");
      for (int i = 0; i < 8; i++) {
        printf("%04X ", snes_instance_->Read(0x7E2000 + i * 2) |
                            (snes_instance_->Read(0x7E2001 + i * 2) << 8));
      }
      printf("\n");
    }
  }
 
  last_cycle_count_ = opcodes;
 
  printf("[EMU] Completed after %d opcodes, PC=$%02X:%04X\n", opcodes, cpu.PB,
         cpu.PC);
 
  if (opcodes >= max_opcodes) {
    last_error_ = "Timeout: exceeded max cycles";
    // Debug: Print some WRAM tilemap values to see if anything was written
    printf("[EMU] WRAM BG1 tilemap sample at $7E2000:\n");
    for (int i = 0; i < 16; i++) {
      printf("  %04X", snes_instance_->Read(0x7E2000 + i * 2) |
                           (snes_instance_->Read(0x7E2000 + i * 2 + 1) << 8));
    }
    printf("\n");
    // Handler didn't complete - PPU state may be corrupted, skip rendering
    // Reset SNES to clean state to prevent crash on destruction
    snes_instance_->Reset(true);
    return;
  }
 
  // 14. Copy WRAM tilemap buffers to VRAM
  // Game drawing routines write to WRAM, but PPU reads from VRAM
  // BG1: WRAM $7E2000 → VRAM $4000 (2KB = 32x32 tilemap)
  for (uint32_t i = 0; i < 0x800; i++) {
    uint8_t lo = snes_instance_->Read(0x7E2000 + i * 2);
    uint8_t hi = snes_instance_->Read(0x7E2000 + i * 2 + 1);
    ppu.vram[0x4000 + i] = lo | (hi << 8);
  }
  // BG2: WRAM $7E4000 → VRAM $4800 (2KB = 32x32 tilemap)
  for (uint32_t i = 0; i < 0x800; i++) {
    uint8_t lo = snes_instance_->Read(0x7E4000 + i * 2);
    uint8_t hi = snes_instance_->Read(0x7E4000 + i * 2 + 1);
    ppu.vram[0x4800 + i] = lo | (hi << 8);
  }
 
  // Debug: Print VRAM tilemap sample to verify data was copied
  printf("[EMU] VRAM tilemap at $4000 (BG1): ");
  for (int i = 0; i < 8; i++) {
    printf("%04X ", ppu.vram[0x4000 + i]);
  }
  printf("\n");
 
  // 15. Force PPU to render the tilemaps
  ppu.HandleFrameStart();
  for (int line = 0; line < 224; line++) {
    ppu.RunLine(line);
  }
  ppu.HandleVblank();
 
  // 15. Get the rendered pixels from PPU
  void* pixels = nullptr;
  int pitch = 0;
  if (renderer_->LockTexture(object_texture_, nullptr, &pixels, &pitch)) {
    snes_instance_->SetPixels(static_cast<uint8_t*>(pixels));
    renderer_->UnlockTexture(object_texture_);
  }
}
 
void DungeonObjectEmulatorPreview::TriggerStaticRender() {
  if (!rom_ || !rom_->is_loaded()) {
    last_error_ = "ROM not loaded";
    return;
  }
 
  last_error_.clear();
 
  // Use shared render service if available
  if (render_service_ && render_service_->IsReady()) {
    emu::render::RenderRequest request;
    request.type = emu::render::RenderTargetType::kDungeonObject;
    request.entity_id = object_id_;
    request.x = object_x_;
    request.y = object_y_;
    request.size = object_size_;
    request.room_id = room_id_;
    request.output_width = 256;
    request.output_height = 256;
 
    auto result = render_service_->Render(request);
    if (result.ok() && result->success) {
      // Update texture with rendered pixels
      if (!object_texture_) {
        object_texture_ = renderer_->CreateTexture(256, 256);
      }
      void* pixels = nullptr;
      int pitch = 0;
      if (renderer_->LockTexture(object_texture_, nullptr, &pixels, &pitch)) {
        // Copy RGBA pixels to texture
        memcpy(pixels, result->rgba_pixels.data(), result->rgba_pixels.size());
        renderer_->UnlockTexture(object_texture_);
      }
      printf("[SERVICE] Rendered object $%04X via EmulatorRenderService\n",
             object_id_);
      return;
    } else {
      // Fall through to legacy rendering
      printf("[SERVICE] Render failed, falling back to legacy: %s\n",
             result.ok() ? result->error.c_str()
                         : std::string(result.status().message()).c_str());
    }
  }
 
  // Legacy rendering path (when no render service is available)
  // Load room for palette/graphics context
  zelda3::Room room = zelda3::LoadRoomFromRom(rom_, room_id_);
  room.SetGameData(game_data_);  // Ensure room has access to GameData
 
  // Get dungeon main palette (palettes 0-5, 90 colors)
  if (!game_data_) {
    last_error_ = "GameData not available";
    return;
  }
  auto dungeon_main_pal_group = game_data_->palette_groups.dungeon_main;
  int palette_id = room.palette;
  if (palette_id < 0 ||
      palette_id >= static_cast<int>(dungeon_main_pal_group.size())) {
    palette_id = 0;
  }
  auto base_palette = dungeon_main_pal_group[palette_id];
 
  // Build full palette including sprite auxiliary palettes (6-7)
  // Dungeon main: palettes 0-5 (90 colors)
  // Sprite aux: palettes 6-7 (30 colors) from ROM
  gfx::SnesPalette palette;
 
  // Copy dungeon main palette (0-89)
  for (size_t i = 0; i < base_palette.size() && i < 90; ++i) {
    palette.AddColor(base_palette[i]);
  }
  // Pad to 90 if needed
  while (palette.size() < 90) {
    palette.AddColor(gfx::SnesColor(0));
  }
 
  // Load sprite auxiliary palettes (90-119) from ROM $0D:D308
  // These are palettes 6-7 used by some dungeon tiles
  // SNES address needs LoROM conversion to PC offset
  constexpr uint32_t kSpriteAuxPaletteSnes = 0x0DD308;  // SNES: bank $0D, addr $D308
  const uint32_t kSpriteAuxPalettePc = SnesToPc(kSpriteAuxPaletteSnes);  // PC: $65308
  for (int i = 0; i < 30; ++i) {
    uint32_t addr = kSpriteAuxPalettePc + i * 2;
    if (addr + 1 < rom_->size()) {
      uint16_t snes_color = rom_->data()[addr] | (rom_->data()[addr + 1] << 8);
      palette.AddColor(gfx::SnesColor(snes_color));
    } else {
      palette.AddColor(gfx::SnesColor(0));
    }
  }
 
  // Load room graphics
  room.LoadRoomGraphics(room.blockset);
  room.CopyRoomGraphicsToBuffer();
  const auto& gfx_buffer = room.get_gfx_buffer();
 
  // Create ObjectDrawer with the room's graphics buffer
  object_drawer_ =
      std::make_unique<zelda3::ObjectDrawer>(rom_, room_id_, gfx_buffer.data());
  object_drawer_->InitializeDrawRoutines();
 
  // Clear background buffers (default 512x512)
  preview_bg1_.ClearBuffer();
  preview_bg2_.ClearBuffer();
 
  // Initialize the internal bitmaps for drawing
  // BackgroundBuffer's bitmap needs to be created before ObjectDrawer can draw
  constexpr int kBgSize = 512;  // Default BackgroundBuffer size
  preview_bg1_.bitmap().Create(kBgSize, kBgSize, 8,
                               std::vector<uint8_t>(kBgSize * kBgSize, 0));
  preview_bg2_.bitmap().Create(kBgSize, kBgSize, 8,
                               std::vector<uint8_t>(kBgSize * kBgSize, 0));
 
  // Create RoomObject and draw it using ObjectDrawer
  zelda3::RoomObject obj(object_id_, object_x_, object_y_, object_size_, 0);
 
  // Create palette group for drawing
  gfx::PaletteGroup preview_palette_group;
  preview_palette_group.AddPalette(palette);
 
  // Draw the object
  auto status = object_drawer_->DrawObject(obj, preview_bg1_, preview_bg2_,
                                           preview_palette_group);
  if (!status.ok()) {
    last_error_ = std::string(status.message());
    printf("[STATIC] DrawObject failed: %s\n", last_error_.c_str());
    return;
  }
 
  printf("[STATIC] Drew object $%04X at (%d,%d) size=%d\n", object_id_,
         object_x_, object_y_, object_size_);
 
  // Get the rendered bitmap data from the BackgroundBuffer
  auto& bg1_bitmap = preview_bg1_.bitmap();
  auto& bg2_bitmap = preview_bg2_.bitmap();
 
  // Create preview bitmap if needed (use 256x256 for display)
  // Use 0xFF as "unwritten/transparent" marker since 0 is a valid palette index
  constexpr int kPreviewSize = 256;
  constexpr uint8_t kTransparentMarker = 0xFF;
  if (preview_bitmap_.width() != kPreviewSize) {
    preview_bitmap_.Create(
        kPreviewSize, kPreviewSize, 8,
        std::vector<uint8_t>(kPreviewSize * kPreviewSize, kTransparentMarker));
  } else {
    // Clear to transparent marker
    std::fill(preview_bitmap_.mutable_data().begin(),
              preview_bitmap_.mutable_data().end(), kTransparentMarker);
  }
 
  // Copy center portion of 512x512 buffer to 256x256 preview
  // This shows the object which is typically placed near center
  auto& preview_data = preview_bitmap_.mutable_data();
  const auto& bg1_data = bg1_bitmap.vector();
  const auto& bg2_data = bg2_bitmap.vector();
 
  // Calculate offset to center on object position
  int offset_x = std::max(0, (object_x_ * 8) - kPreviewSize / 2);
  int offset_y = std::max(0, (object_y_ * 8) - kPreviewSize / 2);
 
  // Clamp to stay within bounds
  offset_x = std::min(offset_x, kBgSize - kPreviewSize);
  offset_y = std::min(offset_y, kBgSize - kPreviewSize);
 
  // Composite: first BG2, then BG1 on top
  // Note: BG buffers use 0 for transparent/unwritten pixels
  for (int y = 0; y < kPreviewSize; ++y) {
    for (int x = 0; x < kPreviewSize; ++x) {
      size_t src_idx = (offset_y + y) * kBgSize + (offset_x + x);
      int dst_idx = y * kPreviewSize + x;
 
      // BG2 first (background layer)
      // Source uses 0 for transparent, but 0 can also be a valid palette index
      // We need to check if the pixel was actually drawn (non-zero in source)
      if (src_idx < bg2_data.size() && bg2_data[src_idx] != 0) {
        preview_data[dst_idx] = bg2_data[src_idx];
      }
      // BG1 on top (foreground layer)
      if (src_idx < bg1_data.size() && bg1_data[src_idx] != 0) {
        preview_data[dst_idx] = bg1_data[src_idx];
      }
    }
  }
 
  // Create/update texture
  if (!object_texture_ && renderer_) {
    object_texture_ = renderer_->CreateTexture(kPreviewSize, kPreviewSize);
  }
 
  if (object_texture_ && renderer_) {
    // Convert indexed bitmap to RGBA for texture
    std::vector<uint8_t> rgba_data(kPreviewSize * kPreviewSize * 4);
    for (int y = 0; y < kPreviewSize; ++y) {
      for (int x = 0; x < kPreviewSize; ++x) {
        size_t idx = y * kPreviewSize + x;
        uint8_t color_idx = preview_data[idx];
 
        if (color_idx == kTransparentMarker) {
          // Unwritten pixel - show background
          rgba_data[idx * 4 + 0] = 32;
          rgba_data[idx * 4 + 1] = 32;
          rgba_data[idx * 4 + 2] = 48;
          rgba_data[idx * 4 + 3] = 255;
        } else if (color_idx < palette.size()) {
          // Valid palette index - look up color (now supports 0-119)
          auto color = palette[color_idx];
          rgba_data[idx * 4 + 0] = color.rgb().x;  // R
          rgba_data[idx * 4 + 1] = color.rgb().y;  // G
          rgba_data[idx * 4 + 2] = color.rgb().z;  // B
          rgba_data[idx * 4 + 3] = 255;            // A
        } else {
          // Out-of-bounds palette index (>119)
          // Show as magenta to indicate error
          rgba_data[idx * 4 + 0] = 255;
          rgba_data[idx * 4 + 1] = 0;
          rgba_data[idx * 4 + 2] = 255;
          rgba_data[idx * 4 + 3] = 255;
        }
      }
    }
 
    void* pixels = nullptr;
    int pitch = 0;
    if (renderer_->LockTexture(object_texture_, nullptr, &pixels, &pitch)) {
      memcpy(pixels, rgba_data.data(), rgba_data.size());
      renderer_->UnlockTexture(object_texture_);
    }
  }
 
  static_render_dirty_ = false;
  printf("[STATIC] Render complete\n");
}
 
const char* DungeonObjectEmulatorPreview::GetObjectName(int id) const {
  if (id < 0) return "Invalid";
 
  if (id < 0x100) {
    // Type 1 objects (0x00-0xFF)
    if (id < static_cast<int>(std::size(zelda3::Type1RoomObjectNames))) {
      return zelda3::Type1RoomObjectNames[id];
    }
  } else if (id < 0x200) {
    // Type 2 objects (0x100-0x1FF)
    int index = id - 0x100;
    if (index < static_cast<int>(std::size(zelda3::Type2RoomObjectNames))) {
      return zelda3::Type2RoomObjectNames[index];
    }
  } else if (id < 0x300) {
    // Type 3 objects (0x200-0x2FF)
    int index = id - 0x200;
    if (index < static_cast<int>(std::size(zelda3::Type3RoomObjectNames))) {
      return zelda3::Type3RoomObjectNames[index];
    }
  }
 
  return "Unknown Object";
}
 
int DungeonObjectEmulatorPreview::GetObjectType(int id) const {
  if (id < 0x100) return 1;
  if (id < 0x200) return 2;
  if (id < 0x300) return 3;
  return 0;
}
 
void DungeonObjectEmulatorPreview::RenderStatusPanel() {
  const auto& theme = AgentUI::GetTheme();
 
  AgentUI::PushPanelStyle();
  ImGui::BeginChild("StatusPanel", ImVec2(0, 100), true);
 
  ImGui::TextColored(theme.text_info, "Execution Status");
  ImGui::Separator();
 
  // Cycle count with status color
  ImGui::Text("Cycles:");
  ImGui::SameLine();
  if (last_cycle_count_ >= 100000) {
    ImGui::TextColored(theme.status_error, "%d (TIMEOUT)", last_cycle_count_);
  } else if (last_cycle_count_ > 0) {
    ImGui::TextColored(theme.status_success, "%d", last_cycle_count_);
  } else {
    ImGui::TextColored(theme.text_secondary_gray, "Not yet executed");
  }
 
  // Error status
  ImGui::Text("Status:");
  ImGui::SameLine();
  if (last_error_.empty()) {
    if (last_cycle_count_ > 0) {
      ImGui::TextColored(theme.status_success, "OK");
    } else {
      ImGui::TextColored(theme.text_secondary_gray, "Ready");
    }
  } else {
    ImGui::TextColored(theme.status_error, "%s", last_error_.c_str());
  }
 
  ImGui::EndChild();
  AgentUI::PopPanelStyle();
}
 
void DungeonObjectEmulatorPreview::RenderObjectBrowser() {
  const auto& theme = AgentUI::GetTheme();
 
  ImGui::SetNextWindowSize(ImVec2(600, 500), ImGuiCond_FirstUseEver);
  if (ImGui::Begin("Object Browser", &show_browser_)) {
    ImGui::TextColored(theme.text_info,
                       "Browse all dungeon objects by type and category");
    ImGui::Separator();
 
    if (ImGui::BeginTabBar("ObjectTypeTabs")) {
      // Type 1 objects tab
      if (ImGui::BeginTabItem("Type 1 (0x00-0xFF)")) {
        ImGui::TextDisabled("Walls, floors, and common dungeon elements");
        ImGui::Separator();
 
        ImGui::BeginChild("Type1List", ImVec2(0, 0), false);
        for (int i = 0; i < static_cast<int>(
                                std::size(zelda3::Type1RoomObjectNames));
             ++i) {
          char label[256];
          snprintf(label, sizeof(label), "0x%02X: %s", i,
                   zelda3::Type1RoomObjectNames[i]);
 
          if (ImGui::Selectable(label, object_id_ == i)) {
            object_id_ = i;
            show_browser_ = false;
            if (render_mode_ == RenderMode::kStatic) {
              TriggerStaticRender();
            } else {
              TriggerEmulatedRender();
            }
          }
        }
        ImGui::EndChild();
 
        ImGui::EndTabItem();
      }
 
      // Type 2 objects tab
      if (ImGui::BeginTabItem("Type 2 (0x100-0x1FF)")) {
        ImGui::TextDisabled("Corners, furniture, and special objects");
        ImGui::Separator();
 
        ImGui::BeginChild("Type2List", ImVec2(0, 0), false);
        for (int i = 0; i < static_cast<int>(
                                std::size(zelda3::Type2RoomObjectNames));
             ++i) {
          char label[256];
          int id = 0x100 + i;
          snprintf(label, sizeof(label), "0x%03X: %s", id,
                   zelda3::Type2RoomObjectNames[i]);
 
          if (ImGui::Selectable(label, object_id_ == id)) {
            object_id_ = id;
            show_browser_ = false;
            if (render_mode_ == RenderMode::kStatic) {
              TriggerStaticRender();
            } else {
              TriggerEmulatedRender();
            }
          }
        }
        ImGui::EndChild();
 
        ImGui::EndTabItem();
      }
 
      // Type 3 objects tab
      if (ImGui::BeginTabItem("Type 3 (0x200-0x2FF)")) {
        ImGui::TextDisabled("Interactive objects, chests, and special items");
        ImGui::Separator();
 
        ImGui::BeginChild("Type3List", ImVec2(0, 0), false);
        for (int i = 0; i < static_cast<int>(
                                std::size(zelda3::Type3RoomObjectNames));
             ++i) {
          char label[256];
          int id = 0x200 + i;
          snprintf(label, sizeof(label), "0x%03X: %s", id,
                   zelda3::Type3RoomObjectNames[i]);
 
          if (ImGui::Selectable(label, object_id_ == id)) {
            object_id_ = id;
            show_browser_ = false;
            if (render_mode_ == RenderMode::kStatic) {
              TriggerStaticRender();
            } else {
              TriggerEmulatedRender();
            }
          }
        }
        ImGui::EndChild();
 
        ImGui::EndTabItem();
      }
 
      ImGui::EndTabBar();
    }
  }
  ImGui::End();
}
 
}  // namespace gui
}  // namespace yaze