menu_orchestrator.cc

Go to the documentation of this file.

#include "menu_orchestrator.h"
 
#include <algorithm>
#include <fstream>
#include <map>
#include <string>
 
#include "absl/status/status.h"
#include "absl/strings/str_format.h"
#include "app/editor/core/content_registry.h"
#include "app/editor/editor.h"
#include "app/editor/editor_manager.h"
#include "app/editor/layout/layout_presets.h"
#include "app/editor/menu/menu_builder.h"
#include "app/editor/menu/right_drawer_manager.h"
#include "app/editor/shell/feedback/popup_manager.h"
#include "app/editor/shell/feedback/toast_manager.h"
#include "app/editor/system/editor_registry.h"
#include "app/editor/system/session/project_manager.h"
#include "app/editor/system/session/rom_file_manager.h"
#include "app/editor/system/session/session_coordinator.h"
#include "app/editor/system/workspace/workspace_window_manager.h"
#include "app/gui/core/icons.h"
#include "app/gui/core/platform_keys.h"
#include "core/features.h"
#include "rom/rom.h"
#include "util/bps.h"
#include "util/file_util.h"
#include "util/i18n/language_manager.h"
#include "zelda3/overworld/overworld_map.h"
 
// Platform-aware shortcut macros for menu display
#define SHORTCUT_CTRL(key) gui::FormatCtrlShortcut(ImGuiKey_##key).c_str()
#define SHORTCUT_CTRL_SHIFT(key) \
  gui::FormatCtrlShiftShortcut(ImGuiKey_##key).c_str()
 
namespace yaze {
namespace editor {
 
namespace {
 
constexpr const char* kLayoutDesignerWindowId = "layout.designer";
 
}  // namespace
 
MenuOrchestrator::MenuOrchestrator(
    EditorManager* editor_manager, MenuBuilder& menu_builder,
    RomFileManager& rom_manager, ProjectManager& project_manager,
    EditorRegistry& editor_registry, SessionCoordinator& session_coordinator,
    ToastManager& toast_manager, PopupManager& popup_manager)
    : editor_manager_(editor_manager),
      menu_builder_(menu_builder),
      rom_manager_(rom_manager),
      project_manager_(project_manager),
      editor_registry_(editor_registry),
      session_coordinator_(session_coordinator),
      toast_manager_(toast_manager),
      popup_manager_(popup_manager) {}
 
void MenuOrchestrator::BuildMainMenu() {
  ClearMenu();
 
  // Build all menu sections in order
  // Traditional order: File, Edit, View, then app-specific menus
  BuildFileMenu();
  BuildEditMenu();
  BuildViewMenu();
  // Windows menu now owns what used to live in the legacy "Window" menu
  // (Sessions, Layout, Snapshots) in addition to the dynamic category
  // toggles from WorkspaceWindowManager.
  BuildPanelsMenu();
  BuildToolsMenu();  // Debug menu items merged into Tools
  BuildHelpMenu();
 
  // Draw the constructed menu
  menu_builder_.Draw();
 
  // Render any deferred modal popups owned by the menu layer. These run
  // after the menu stack unwinds so the popup has a clean ImGui stack.
  if (open_save_snapshot_modal_) {
    ImGui::OpenPopup("Save Layout Snapshot##menu_orch_save_snapshot");
    open_save_snapshot_modal_ = false;
  }
  if (ImGui::BeginPopupModal("Save Layout Snapshot##menu_orch_save_snapshot",
                             nullptr, ImGuiWindowFlags_AlwaysAutoResize)) {
    ImGui::TextUnformatted("Snapshot name:");
    ImGui::SetNextItemWidth(320.0f);
    const bool submitted =
        ImGui::InputText("##snapshot_name", save_snapshot_name_buffer_,
                         sizeof(save_snapshot_name_buffer_),
                         ImGuiInputTextFlags_EnterReturnsTrue);
    const bool has_name = save_snapshot_name_buffer_[0] != '\0';
    ImGui::Separator();
    if ((ImGui::Button("Save", ImVec2(120, 0)) || submitted) && has_name) {
      if (editor_manager_) {
        editor_manager_->SaveLayoutSnapshotAs(save_snapshot_name_buffer_);
      }
      save_snapshot_name_buffer_[0] = '\0';
      ImGui::CloseCurrentPopup();
    }
    ImGui::SameLine();
    if (ImGui::Button("Cancel", ImVec2(120, 0))) {
      save_snapshot_name_buffer_[0] = '\0';
      ImGui::CloseCurrentPopup();
    }
    ImGui::EndPopup();
  }
 
  menu_needs_refresh_ = false;
}
 
void MenuOrchestrator::BuildFileMenu() {
  menu_builder_.BeginMenu("File");
  AddFileMenuItems();
  menu_builder_.EndMenu();
}
 
void MenuOrchestrator::AddFileMenuItems() {
  // ROM Operations
  menu_builder_
      .Item(
          "Open ROM / Project...", ICON_MD_FILE_OPEN, [this]() { OnOpenRom(); },
          SHORTCUT_CTRL(O))
      .Item(
          "Save ROM", ICON_MD_SAVE, [this]() { OnSaveRom(); }, SHORTCUT_CTRL(S),
          [this]() { return CanSaveRom(); })
      .Item(
          "Save As...", ICON_MD_SAVE_AS, [this]() { OnSaveRomAs(); }, nullptr,
          [this]() { return CanSaveRom(); })
      .Item(
          "Save Scope...", ICON_MD_TUNE,
          [this]() { popup_manager_.Show(PopupID::kSaveScope); }, nullptr,
          [this]() { return CanSaveRom(); })
      .Separator();
 
  // Project Operations
  menu_builder_
      .Item("New Project", ICON_MD_CREATE_NEW_FOLDER,
            [this]() { OnCreateProject(); })
      .Item("Open Project Only...", ICON_MD_FOLDER_OPEN,
            [this]() { OnOpenProject(); })
      .Item(
          "Save Project", ICON_MD_SAVE, [this]() { OnSaveProject(); }, nullptr,
          [this]() { return CanSaveProject(); })
      .Item(
          "Save Project As...", ICON_MD_SAVE_AS,
          [this]() { OnSaveProjectAs(); }, nullptr,
          [this]() { return CanSaveProject(); })
      .Item(
          "Project Management...", ICON_MD_FOLDER_SPECIAL,
          [this]() { OnShowProjectManagement(); }, nullptr,
          [this]() { return CanSaveProject(); })
      .Item(
          "Edit Project File...", ICON_MD_DESCRIPTION,
          [this]() { OnShowProjectFileEditor(); }, nullptr,
          [this]() { return HasProjectFile(); })
      .Separator();
 
  // Settings and Quit (ROM analysis / backup / BPS live under Tools)
  menu_builder_
      .Item("Settings", ICON_MD_SETTINGS, [this]() { OnShowSettings(); })
      .Separator()
      .Item(
          "Quit", ICON_MD_EXIT_TO_APP, [this]() { OnQuit(); },
          SHORTCUT_CTRL(Q));
}
 
void MenuOrchestrator::BuildEditMenu() {
  menu_builder_.BeginMenu("Edit");
  AddEditMenuItems();
  menu_builder_.EndMenu();
}
 
void MenuOrchestrator::AddEditMenuItems() {
  // Undo/Redo operations - delegate to current editor
  menu_builder_
      .Item(
          "Undo", ICON_MD_UNDO, [this]() { OnUndo(); }, SHORTCUT_CTRL(Z),
          [this]() { return HasCurrentEditor(); })
      .Item(
          "Redo", ICON_MD_REDO, [this]() { OnRedo(); }, SHORTCUT_CTRL(Y),
          [this]() { return HasCurrentEditor(); })
      .Separator();
 
  // Clipboard operations - delegate to current editor
  menu_builder_
      .Item(
          "Cut", ICON_MD_CONTENT_CUT, [this]() { OnCut(); }, SHORTCUT_CTRL(X),
          [this]() { return HasCurrentEditor(); })
      .Item(
          "Copy", ICON_MD_CONTENT_COPY, [this]() { OnCopy(); },
          SHORTCUT_CTRL(C), [this]() { return HasCurrentEditor(); })
      .Item(
          "Paste", ICON_MD_CONTENT_PASTE, [this]() { OnPaste(); },
          SHORTCUT_CTRL(V), [this]() { return HasCurrentEditor(); })
      .Separator();
 
  // Search operations (Find in Files moved to Tools > Global Search)
  menu_builder_.Item(
      "Find", ICON_MD_SEARCH, [this]() { OnFind(); }, SHORTCUT_CTRL(F),
      [this]() { return HasCurrentEditor(); });
}
 
void MenuOrchestrator::BuildViewMenu() {
  menu_builder_.BeginMenu("View");
  AddViewMenuItems();
  menu_builder_.EndMenu();
}
 
void MenuOrchestrator::AddViewMenuItems() {
  AddAppearanceMenuItems();
  menu_builder_.Separator();
 
  // Right drawers — shared catalog with menu-bar overflow / header switcher.
  AddDrawersMenuItems();
  menu_builder_.Separator();
 
  // Editor selection (Switch Editor)
  menu_builder_.Item(
      "Switch Editor...", ICON_MD_SWAP_HORIZ,
      [this]() { OnShowEditorSelection(); }, SHORTCUT_CTRL(E),
      [this]() { return HasActiveRom(); });
}
 
void MenuOrchestrator::AddAppearanceMenuItems() {
  // Appearance/Layout controls
  menu_builder_
      .Item(
          "Show Sidebar", ICON_MD_VIEW_SIDEBAR,
          [this]() {
            if (window_manager_)
              window_manager_->ToggleSidebarVisibility();
          },
          SHORTCUT_CTRL(B), nullptr,
          [this]() {
            return window_manager_ && window_manager_->IsSidebarVisible();
          })
      .Item(
          "Show Status Bar", ICON_MD_HORIZONTAL_RULE,
          [this]() {
            if (user_settings_) {
              user_settings_->prefs().show_status_bar =
                  !user_settings_->prefs().show_status_bar;
              user_settings_->Save();
              if (status_bar_) {
                status_bar_->SetEnabled(
                    user_settings_->prefs().show_status_bar);
              }
            }
          },
          nullptr, nullptr,
          [this]() {
            return user_settings_ && user_settings_->prefs().show_status_bar;
          })
      .Separator()
      .Item("Display Settings", ICON_MD_DISPLAY_SETTINGS,
            [this]() { OnShowDisplaySettings(); })
      .Item("Welcome Screen", ICON_MD_HOME,
            [this]() { OnShowWelcomeScreen(); });
}
 
void MenuOrchestrator::AddDrawersMenuItems() {
  auto* drawers =
      editor_manager_ ? editor_manager_->right_drawer_manager() : nullptr;
  if (!drawers) {
    return;
  }
 
  menu_builder_.BeginSubMenu("Drawers", ICON_MD_VERTICAL_SPLIT);
  for (const DrawerCatalogEntry& entry : GetDrawerCatalog()) {
    const auto type = entry.type;
    menu_builder_.Item(
        entry.name, entry.icon,
        [drawers, type]() { drawers->ToggleDrawer(type); }, nullptr, nullptr,
        [drawers, type]() { return drawers->IsDrawerActive(type); });
  }
  menu_builder_.EndMenu();
}
 
// Layout presets remain under Windows > Layout (AddLayoutSubmenu).
// The former View > Layout duplicate was removed to keep one home for layout.
 
void MenuOrchestrator::BuildPanelsMenu() {
  // Use CustomMenu to integrate dynamic panel content with the menu builder
  menu_builder_.CustomMenu("Windows", [this]() { AddPanelsMenuItems(); });
}
 
void MenuOrchestrator::AddPanelsMenuItems() {
  if (!window_manager_) {
    return;
  }
 
  const size_t session_id = session_coordinator_.GetActiveSessionId();
  std::string active_category = window_manager_->GetActiveCategory();
  auto all_categories = window_manager_->GetAllCategories(session_id);
 
  // Window Browser action at top
  if (ImGui::MenuItem(
          absl::StrFormat("%s Window Browser", ICON_MD_APPS).c_str(),
          SHORTCUT_CTRL_SHIFT(B))) {
    OnShowPanelBrowser();
  }
  if (ImGui::MenuItem(
          absl::StrFormat("%s Show All Windows", ICON_MD_VISIBILITY).c_str())) {
    window_manager_->ShowAllWindowsInSession(session_id);
  }
  if (ImGui::MenuItem(
          absl::StrFormat("%s Hide All Windows", ICON_MD_VISIBILITY_OFF)
              .c_str())) {
    window_manager_->HideAllWindowsInSession(session_id);
  }
  ImGui::Separator();
 
  // Sessions and Layout — folded in from the former "Window" top-level menu.
  // These draw directly against ImGui (not through MenuBuilder) because
  // CustomMenu's callback runs *inside* an already-open BeginMenu scope.
  AddSessionsSubmenu();
  AddLayoutSubmenu();
  AddSidebarSubmenu();
  ImGui::Separator();
 
  if (all_categories.empty()) {
    ImGui::TextDisabled("No windows available");
    return;
  }
 
  // Show all categories as direct submenus (no nested "All Categories" wrapper)
  for (const auto& category : all_categories) {
    // Mark active category with icon
    std::string label = category;
    if (category == active_category) {
      label = absl::StrFormat("%s %s", ICON_MD_FOLDER_OPEN, category);
    } else {
      label = absl::StrFormat("%s %s", ICON_MD_FOLDER, category);
    }
 
    if (ImGui::BeginMenu(label.c_str())) {
      auto cards = window_manager_->GetWindowsInCategory(session_id, category);
 
      if (cards.empty()) {
        ImGui::TextDisabled("No windows in this category");
      } else {
        if (ImGui::MenuItem(
                absl::StrFormat("%s Show Category", ICON_MD_VISIBILITY)
                    .c_str())) {
          window_manager_->ShowAllWindowsInCategory(session_id, category);
        }
        if (ImGui::MenuItem(
                absl::StrFormat("%s Hide Category", ICON_MD_VISIBILITY_OFF)
                    .c_str())) {
          window_manager_->HideAllWindowsInCategory(session_id, category);
        }
        ImGui::Separator();
 
        for (const auto& card : cards) {
          bool is_visible =
              window_manager_->IsWindowOpen(session_id, card.card_id);
          const char* shortcut =
              card.shortcut_hint.empty() ? nullptr : card.shortcut_hint.c_str();
 
          // Show icon for visible panels
          std::string item_label =
              is_visible
                  ? absl::StrFormat("%s %s", ICON_MD_CHECK_BOX,
                                    card.display_name)
                  : absl::StrFormat("%s %s", ICON_MD_CHECK_BOX_OUTLINE_BLANK,
                                    card.display_name);
 
          if (ImGui::MenuItem(item_label.c_str(), shortcut)) {
            window_manager_->ToggleWindow(session_id, card.card_id);
          }
        }
      }
      ImGui::EndMenu();
    }
  }
}
 
void MenuOrchestrator::BuildToolsMenu() {
  menu_builder_.BeginMenu("Tools");
  AddToolsMenuItems();
  menu_builder_.EndMenu();
}
 
void MenuOrchestrator::AddToolsMenuItems() {
  AddSearchMenuItems();
  AddHackWorkflowMenuItems();
  menu_builder_.Separator();
 
  AddRomAnalysisMenuItems();
  AddAsarIntegrationMenuItems();
  menu_builder_.Separator();
 
  AddDevelopmentMenuItems();
 
#ifdef YAZE_ENABLE_TESTING
  AddTestingMenuItems();
#endif
 
  // ImGui Debug (moved from Debug menu)
  menu_builder_.BeginSubMenu("ImGui Debug", ICON_MD_BUG_REPORT)
      .Item("ImGui Demo", ICON_MD_HELP, [this]() { OnShowImGuiDemo(); })
      .Item("ImGui Metrics", ICON_MD_ANALYTICS,
            [this]() { OnShowImGuiMetrics(); })
      .EndMenu()
      .Separator();
 
#ifdef YAZE_WITH_GRPC
  AddCollaborationMenuItems();
#endif
}
 
void MenuOrchestrator::AddSearchMenuItems() {
  // Search & Navigation
  menu_builder_
      .Item(
          "Global Search", ICON_MD_SEARCH, [this]() { OnShowGlobalSearch(); },
          SHORTCUT_CTRL_SHIFT(F))
      .Item(
          "Command Palette", ICON_MD_SEARCH,
          [this]() { OnShowCommandPalette(); }, SHORTCUT_CTRL_SHIFT(P))
      .Item(
          "Find Window…", ICON_MD_DASHBOARD, [this]() { OnShowPanelFinder(); },
          SHORTCUT_CTRL(P))
      .Item("Resource Label Manager", ICON_MD_LABEL,
            [this]() { OnShowResourceLabelManager(); });
}
 
void MenuOrchestrator::AddHackWorkflowMenuItems() {
  using WorkflowItem = ContentRegistry::WorkflowActions::ActionDef;
 
  std::map<std::string, std::vector<WorkflowItem>> grouped_items;
 
  if (window_manager_) {
    const size_t session_id = session_coordinator_.GetActiveSessionId();
    const auto categories = window_manager_->GetAllCategories(session_id);
    for (const auto& category : categories) {
      for (const auto& descriptor :
           window_manager_->GetWindowsInCategory(session_id, category)) {
        if (descriptor.workflow_group.empty()) {
          continue;
        }
        WorkflowItem item;
        item.id = absl::StrFormat("panel.%s", descriptor.card_id);
        item.group = descriptor.workflow_group;
        item.label = descriptor.workflow_label.empty()
                         ? descriptor.display_name
                         : descriptor.workflow_label;
        item.description =
            descriptor.workflow_description.empty()
                ? absl::StrFormat("Open %s", descriptor.display_name)
                : descriptor.workflow_description;
        item.shortcut = descriptor.shortcut_hint;
        item.priority = descriptor.workflow_priority;
        item.callback = [this, session_id, panel_id = descriptor.card_id]() {
          if (window_manager_) {
            window_manager_->OpenWindow(session_id, panel_id);
          }
        };
        item.enabled = descriptor.enabled_condition;
        const std::string group = item.group.empty() ? "General" : item.group;
        grouped_items[group].push_back(std::move(item));
      }
    }
  }
 
  for (const auto& action : ContentRegistry::WorkflowActions::GetAll()) {
    const std::string group = action.group.empty() ? "General" : action.group;
    grouped_items[group].push_back(action);
  }
 
  if (grouped_items.empty()) {
    return;
  }
 
  menu_builder_.BeginSubMenu("Hack Workflows", ICON_MD_ROUTE);
  for (auto& [group, items] : grouped_items) {
    std::sort(items.begin(), items.end(),
              [](const WorkflowItem& lhs, const WorkflowItem& rhs) {
                if (lhs.priority != rhs.priority) {
                  return lhs.priority < rhs.priority;
                }
                return lhs.label < rhs.label;
              });
    menu_builder_.BeginSubMenu(group.c_str(), ICON_MD_WORKSPACE_PREMIUM);
    for (const auto& item : items) {
      MenuBuilder::EnabledCheck enabled = item.enabled;
      menu_builder_.Item(
          item.label.c_str(), item.callback,
          item.shortcut.empty() ? nullptr : item.shortcut.c_str(), enabled);
    }
    menu_builder_.EndMenu();
  }
  menu_builder_.EndMenu();
}
 
void MenuOrchestrator::AddRomAnalysisMenuItems() {
  // ROM Analysis (document tooling moved from File)
  menu_builder_.BeginSubMenu("ROM Analysis", ICON_MD_STORAGE)
      .Item(
          "ROM Information", ICON_MD_INFO, [this]() { OnShowRomInfo(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Item(
          "Create Backup", ICON_MD_BACKUP, [this]() { OnCreateBackup(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Item(
          "ROM Backups...", ICON_MD_BACKUP,
          [this]() { popup_manager_.Show(PopupID::kRomBackups); }, nullptr,
          [this]() { return HasActiveRom(); })
      .Item(
          "Validate ROM", ICON_MD_CHECK_CIRCLE, [this]() { OnValidateRom(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Item(
          "Data Integrity Check", ICON_MD_ANALYTICS,
          [this]() { OnRunDataIntegrityCheck(); }, nullptr,
          [this]() { return HasActiveRom(); })
      .Item(
          "Test Save/Load", ICON_MD_SAVE_ALT, [this]() { OnTestSaveLoad(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Separator()
      .Item(
          "Export BPS Patch...", ICON_MD_DIFFERENCE,
          [this]() { OnExportBpsPatch(); }, nullptr,
          [this]() { return HasActiveRom(); })
      .Item(
          "Apply BPS Patch...", ICON_MD_BUILD, [this]() { OnApplyBpsPatch(); },
          nullptr, [this]() { return HasActiveRom(); })
      .EndMenu();
 
  // ZSCustomOverworld (moved from Debug menu)
  menu_builder_.BeginSubMenu("ZSCustomOverworld", ICON_MD_CODE)
      .Item(
          "Check ROM Version", ICON_MD_INFO, [this]() { OnCheckRomVersion(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Item(
          "Upgrade ROM", ICON_MD_UPGRADE, [this]() { OnUpgradeRom(); }, nullptr,
          [this]() { return HasActiveRom(); })
      .Item("Toggle Custom Loading", ICON_MD_SETTINGS,
            [this]() { OnToggleCustomLoading(); })
      .EndMenu();
}
 
void MenuOrchestrator::AddAsarIntegrationMenuItems() {
  // Asar Integration (moved from Debug menu)
  menu_builder_.BeginSubMenu("Asar Integration", ICON_MD_BUILD)
      .Item("Asar Status", ICON_MD_INFO,
            [this]() { popup_manager_.Show(PopupID::kAsarIntegration); })
      .Item(
          "Toggle ASM Patch", ICON_MD_CODE, [this]() { OnToggleAsarPatch(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Item("Load ASM File", ICON_MD_FOLDER_OPEN, [this]() { OnLoadAsmFile(); })
      .EndMenu();
}
 
void MenuOrchestrator::AddDevelopmentMenuItems() {
  // Development Tools — Agent drawers live under View > Drawers.
  menu_builder_.BeginSubMenu("Development", ICON_MD_DEVELOPER_MODE)
      .Item(
          "Memory Editor", ICON_MD_MEMORY, [this]() { OnShowMemoryEditor(); },
          nullptr, [this]() { return HasActiveRom(); })
      .Item("Assembly Editor", ICON_MD_CODE,
            [this]() { OnShowAssemblyEditor(); })
      .Item("Feature Flags", ICON_MD_FLAG,
            [this]() { popup_manager_.Show(PopupID::kFeatureFlags); })
      .Item("Performance Dashboard", ICON_MD_SPEED,
            [this]() { OnShowPerformanceDashboard(); })
      .EndMenu();
}
 
void MenuOrchestrator::AddTestingMenuItems() {
  // Testing (moved from Debug menu)
  menu_builder_.BeginSubMenu("Testing", ICON_MD_SCIENCE);
#ifdef YAZE_ENABLE_TESTING
  menu_builder_
      .Item(
          "Test Dashboard", ICON_MD_DASHBOARD,
          [this]() { OnShowTestDashboard(); }, SHORTCUT_CTRL(T))
      .Item("Run All Tests", ICON_MD_PLAY_ARROW, [this]() { OnRunAllTests(); })
      .Item("Run Unit Tests", ICON_MD_CHECK_BOX, [this]() { OnRunUnitTests(); })
      .Item("Run Integration Tests", ICON_MD_INTEGRATION_INSTRUCTIONS,
            [this]() { OnRunIntegrationTests(); })
      .Item("Run E2E Tests", ICON_MD_VISIBILITY, [this]() { OnRunE2ETests(); });
#else
  menu_builder_.DisabledItem(
      "Testing support disabled (YAZE_ENABLE_TESTING=OFF)", ICON_MD_INFO);
#endif
  menu_builder_.EndMenu();
}
 
#ifdef YAZE_WITH_GRPC
void MenuOrchestrator::AddCollaborationMenuItems() {
  // Collaboration (GRPC builds only)
  menu_builder_.BeginSubMenu("Collaborate", ICON_MD_PEOPLE)
      .Item("Start Collaboration Session", ICON_MD_PLAY_CIRCLE,
            [this]() { OnStartCollaboration(); })
      .Item("Join Collaboration Session", ICON_MD_GROUP_ADD,
            [this]() { OnJoinCollaboration(); })
      .Item("Network Status", ICON_MD_CLOUD,
            [this]() { OnShowNetworkStatus(); })
      .EndMenu();
}
#endif
 
// Sessions submenu (folded from the former top-level "Window" menu).
// Drawn inline inside the "Windows" CustomMenu callback using raw ImGui
// calls so the entries land in the same menu scope.
void MenuOrchestrator::AddSessionsSubmenu() {
  if (ImGui::BeginMenu(absl::StrFormat("%s Sessions", ICON_MD_TAB).c_str())) {
    if (ImGui::MenuItem(absl::StrFormat("%s New Session", ICON_MD_ADD).c_str(),
                        SHORTCUT_CTRL_SHIFT(N))) {
      OnCreateNewSession();
    }
    if (ImGui::MenuItem(
            absl::StrFormat("%s Duplicate Session", ICON_MD_CONTENT_COPY)
                .c_str(),
            nullptr, false, HasActiveRom())) {
      OnDuplicateCurrentSession();
    }
    if (ImGui::MenuItem(
            absl::StrFormat("%s Close Session", ICON_MD_CLOSE).c_str(),
            SHORTCUT_CTRL_SHIFT(W), false, HasMultipleSessions())) {
      OnCloseCurrentSession();
    }
    ImGui::Separator();
    if (ImGui::MenuItem(
            absl::StrFormat("%s Session Switcher", ICON_MD_SWITCH_ACCOUNT)
                .c_str(),
            SHORTCUT_CTRL(Tab), false, HasMultipleSessions())) {
      OnShowSessionSwitcher();
    }
    if (ImGui::MenuItem(
            absl::StrFormat("%s Session Manager", ICON_MD_VIEW_LIST).c_str())) {
      OnShowSessionManager();
    }
    ImGui::EndMenu();
  }
}
 
// Layout submenu (folded from the former top-level "Window" menu).
// Contains Save/Load/Reset, session snapshots, and named presets.
void MenuOrchestrator::AddLayoutSubmenu() {
  const bool layout_enabled = HasCurrentEditor();
  auto apply_preset = [this](const char* name) {
    if (editor_manager_)
      editor_manager_->ApplyLayoutPreset(name);
  };
  auto apply_profile = [this](const char* name) {
    if (editor_manager_)
      editor_manager_->ApplyLayoutProfile(name);
  };
 
  if (ImGui::BeginMenu(
          absl::StrFormat("%s Layout", ICON_MD_VIEW_QUILT).c_str())) {
    if (ImGui::MenuItem(absl::StrFormat("%s Open Layout Designer",
                                        ICON_MD_DASHBOARD_CUSTOMIZE)
                            .c_str(),
                        nullptr, false, window_manager_ != nullptr)) {
      OnShowLayoutDesigner();
    }
    ImGui::Separator();
 
    if (ImGui::MenuItem(absl::StrFormat("%s Save Layout", ICON_MD_SAVE).c_str(),
                        SHORTCUT_CTRL_SHIFT(S))) {
      OnSaveWorkspaceLayout();
    }
    if (ImGui::MenuItem(
            absl::StrFormat("%s Load Layout", ICON_MD_FOLDER_OPEN).c_str(),
            SHORTCUT_CTRL_SHIFT(O))) {
      OnLoadWorkspaceLayout();
    }
    if (ImGui::MenuItem(
            absl::StrFormat("%s Reset Layout", ICON_MD_RESET_TV).c_str())) {
      OnResetWorkspaceLayout();
    }
    if (ImGui::MenuItem(
            absl::StrFormat("%s Reset Active Editor Layout", ICON_MD_REFRESH)
                .c_str(),
            nullptr, false, layout_enabled)) {
      if (editor_manager_)
        editor_manager_->ResetCurrentEditorLayout();
    }
 
    ImGui::Separator();
    if (ImGui::BeginMenu(
            absl::StrFormat("%s Snapshots", ICON_MD_BOOKMARKS).c_str(),
            layout_enabled)) {
      if (ImGui::MenuItem(
              absl::StrFormat("%s Save Snapshot As...", ICON_MD_BOOKMARK_ADD)
                  .c_str(),
              nullptr, false, layout_enabled)) {
        save_snapshot_name_buffer_[0] = '\0';
        open_save_snapshot_modal_ = true;
      }
 
      // Named snapshots (session-scoped, in-memory).
      std::vector<std::string> named =
          editor_manager_ ? editor_manager_->ListLayoutSnapshots()
                          : std::vector<std::string>{};
      if (!named.empty()) {
        ImGui::Separator();
        for (const auto& name : named) {
          ImGui::PushID(name.c_str());
          if (ImGui::MenuItem(
                  absl::StrFormat("%s %s", ICON_MD_RESTORE, name).c_str(),
                  nullptr, false, layout_enabled)) {
            if (editor_manager_)
              editor_manager_->RestoreLayoutSnapshot(name);
          }
          ImGui::SameLine(ImGui::GetContentRegionAvail().x);
          if (ImGui::SmallButton(ICON_MD_DELETE)) {
            if (editor_manager_)
              editor_manager_->DeleteLayoutSnapshot(name);
          }
          ImGui::PopID();
        }
      }
 
      ImGui::Separator();
      // Legacy unnamed temporary slot (backward-compatible Capture/Restore).
      if (ImGui::MenuItem(
              absl::StrFormat("%s Capture Unnamed", ICON_MD_BOOKMARK_ADD)
                  .c_str(),
              nullptr, false, layout_enabled)) {
        if (editor_manager_)
          editor_manager_->CaptureTemporaryLayoutSnapshot();
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Restore Unnamed", ICON_MD_RESTORE).c_str(),
              nullptr, false, layout_enabled)) {
        if (editor_manager_)
          editor_manager_->RestoreTemporaryLayoutSnapshot();
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Clear Unnamed", ICON_MD_BOOKMARK_REMOVE)
                  .c_str(),
              nullptr, false, layout_enabled)) {
        if (editor_manager_)
          editor_manager_->ClearTemporaryLayoutSnapshot();
      }
      ImGui::EndMenu();
    }
 
    ImGui::Separator();
    if (ImGui::BeginMenu(
            absl::StrFormat("%s Presets", ICON_MD_DASHBOARD).c_str())) {
      if (ImGui::MenuItem(absl::StrFormat("%s Code", ICON_MD_CODE).c_str(),
                          nullptr, false, layout_enabled)) {
        apply_profile("code");
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Debug", ICON_MD_BUG_REPORT).c_str(), nullptr,
              false, layout_enabled)) {
        apply_profile("debug");
      }
      if (ImGui::MenuItem(absl::StrFormat("%s Mapping", ICON_MD_MAP).c_str(),
                          nullptr, false, layout_enabled)) {
        apply_profile("mapping");
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Chat + Agent", ICON_MD_SMART_TOY).c_str(),
              nullptr, false, layout_enabled)) {
        apply_profile("chat");
      }
      ImGui::Separator();
      if (ImGui::MenuItem(
              absl::StrFormat("%s Minimal", ICON_MD_VIEW_COMPACT).c_str(),
              nullptr, false, layout_enabled)) {
        apply_preset("Minimal");
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Developer", ICON_MD_DEVELOPER_MODE).c_str(),
              nullptr, false, layout_enabled)) {
        OnLoadDeveloperLayout();
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Designer", ICON_MD_DESIGN_SERVICES).c_str(),
              nullptr, false, layout_enabled)) {
        OnLoadDesignerLayout();
      }
      if (ImGui::MenuItem(absl::StrFormat("%s Modder", ICON_MD_BUILD).c_str(),
                          nullptr, false, layout_enabled)) {
        OnLoadModderLayout();
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Overworld Expert", ICON_MD_MAP).c_str(),
              nullptr, false, layout_enabled)) {
        apply_preset("Overworld Expert");
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Dungeon Expert", ICON_MD_CASTLE).c_str(),
              nullptr, false, layout_enabled)) {
        apply_preset("Dungeon Expert");
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Testing", ICON_MD_SCIENCE).c_str(), nullptr,
              false, layout_enabled)) {
        apply_preset("Testing");
      }
      if (ImGui::MenuItem(
              absl::StrFormat("%s Audio", ICON_MD_MUSIC_NOTE).c_str(), nullptr,
              false, layout_enabled)) {
        apply_preset("Audio");
      }
      ImGui::Separator();
      if (ImGui::MenuItem(
              absl::StrFormat("%s Manage Presets...", ICON_MD_TUNE).c_str())) {
        OnShowLayoutPresets();
      }
      ImGui::EndMenu();
    }
    ImGui::EndMenu();
  }
}
 
// Sidebar submenu — surfaces ActivityBar pin/hide/reorder operations so the
// feature is discoverable from the menubar without touching the rail.
void MenuOrchestrator::AddSidebarSubmenu() {
  if (!user_settings_) {
    return;
  }
 
  if (!ImGui::BeginMenu(
          absl::StrFormat("%s Sidebar", ICON_MD_VIEW_SIDEBAR).c_str())) {
    return;
  }
 
  auto persist = [this]() {
    (void)user_settings_->Save();
  };
  auto& prefs = user_settings_->prefs();
 
  if (ImGui::MenuItem(
          absl::StrFormat("%s Reset Order", ICON_MD_RESTART_ALT).c_str(),
          nullptr, false, !prefs.sidebar_order.empty())) {
    prefs.sidebar_order.clear();
    persist();
  }
  if (ImGui::MenuItem(
          absl::StrFormat("%s Show All Categories", ICON_MD_VISIBILITY).c_str(),
          nullptr, false, !prefs.sidebar_hidden.empty())) {
    prefs.sidebar_hidden.clear();
    persist();
  }
 
  ImGui::Separator();
 
  const size_t session_id = session_coordinator_.GetActiveSessionId();
  std::vector<std::string> categories;
  if (window_manager_) {
    categories = window_manager_->GetAllCategories(session_id);
  }
 
  // Build pinned list (in canonical category order).
  std::vector<std::string> pinned_list;
  std::vector<std::string> hidden_list;
  for (const auto& cat : categories) {
    if (cat == WorkspaceWindowManager::kDashboardCategory)
      continue;
    if (prefs.sidebar_pinned.count(cat))
      pinned_list.push_back(cat);
    if (prefs.sidebar_hidden.count(cat))
      hidden_list.push_back(cat);
  }
 
  if (ImGui::BeginMenu(
          absl::StrFormat("%s Pinned", ICON_MD_PUSH_PIN).c_str())) {
    if (pinned_list.empty()) {
      ImGui::TextDisabled("(none)");
    } else {
      for (const auto& cat : pinned_list) {
        ImGui::PushID(cat.c_str());
        if (ImGui::MenuItem(
                absl::StrFormat("%s Unpin %s", ICON_MD_CLOSE, cat).c_str())) {
          prefs.sidebar_pinned.erase(cat);
          persist();
        }
        ImGui::PopID();
      }
    }
    ImGui::EndMenu();
  }
 
  if (ImGui::BeginMenu(
          absl::StrFormat("%s Hidden", ICON_MD_VISIBILITY_OFF).c_str())) {
    if (hidden_list.empty()) {
      ImGui::TextDisabled("(none)");
    } else {
      for (const auto& cat : hidden_list) {
        ImGui::PushID(cat.c_str());
        if (ImGui::MenuItem(
                absl::StrFormat("%s Show %s", ICON_MD_VISIBILITY, cat)
                    .c_str())) {
          prefs.sidebar_hidden.erase(cat);
          persist();
        }
        ImGui::PopID();
      }
    }
    ImGui::EndMenu();
  }
 
  ImGui::Separator();
 
  // Per-category toggles (pin/hide) for all categories. Keeps the menu
  // discoverable even for users who haven't right-clicked the rail.
  if (ImGui::BeginMenu(absl::StrFormat("%s Customize", ICON_MD_TUNE).c_str())) {
    if (categories.empty()) {
      ImGui::TextDisabled("No categories available");
    } else {
      for (const auto& cat : categories) {
        if (cat == WorkspaceWindowManager::kDashboardCategory)
          continue;
        ImGui::PushID(cat.c_str());
        const bool pinned = prefs.sidebar_pinned.count(cat) > 0;
        const bool hidden = prefs.sidebar_hidden.count(cat) > 0;
        if (ImGui::BeginMenu(cat.c_str())) {
          if (ImGui::MenuItem(pinned ? "Unpin from top" : "Pin to top", nullptr,
                              pinned)) {
            if (pinned) {
              prefs.sidebar_pinned.erase(cat);
            } else {
              prefs.sidebar_pinned.insert(cat);
            }
            persist();
          }
          if (ImGui::MenuItem(hidden ? "Show on sidebar" : "Hide from sidebar",
                              nullptr, hidden)) {
            if (hidden) {
              prefs.sidebar_hidden.erase(cat);
            } else {
              prefs.sidebar_hidden.insert(cat);
            }
            persist();
          }
          ImGui::EndMenu();
        }
        ImGui::PopID();
      }
    }
    ImGui::EndMenu();
  }
 
  ImGui::EndMenu();
}
 
void MenuOrchestrator::BuildHelpMenu() {
  menu_builder_.BeginMenu("Help");
  AddHelpMenuItems();
  menu_builder_.EndMenu();
}
 
void MenuOrchestrator::AddHelpMenuItems() {
  // Note: Asar Integration moved to Tools menu to reduce redundancy
  menu_builder_
      .Item("Getting Started", ICON_MD_PLAY_ARROW,
            [this]() { OnShowGettingStarted(); })
      .Item(
          "Keyboard Shortcuts", ICON_MD_KEYBOARD,
          [this]() {
            if (window_manager_) {
              window_manager_->TriggerShowShortcuts();
            }
          },
          SHORTCUT_CTRL_SHIFT(Slash))
      .Item("Build Instructions", ICON_MD_BUILD,
            [this]() { OnShowBuildInstructions(); })
      .Item("CLI Usage", ICON_MD_TERMINAL, [this]() { OnShowCLIUsage(); })
      .Separator()
      .Item("Supported Features", ICON_MD_CHECK_CIRCLE,
            [this]() { OnShowSupportedFeatures(); })
      .Item("What's New", ICON_MD_NEW_RELEASES, [this]() { OnShowWhatsNew(); })
      .Separator()
      .Item("Troubleshooting", ICON_MD_BUILD_CIRCLE,
            [this]() { OnShowTroubleshooting(); })
      .Item("Contributing", ICON_MD_VOLUNTEER_ACTIVISM,
            [this]() { OnShowContributing(); })
      .Separator()
      .Item("About", ICON_MD_INFO, [this]() { OnShowAbout(); }, "F1");
 
  menu_builder_.Separator();
  menu_builder_.BeginSubMenu("Language", ICON_MD_LANGUAGE);
  for (const std::string& locale :
       i18n::LanguageManager::Get().GetAvailableLocales()) {
    menu_builder_.Item(
        locale.c_str(), nullptr,
        [locale]() { i18n::LanguageManager::Get().SetLanguage(locale); },
        nullptr, nullptr,
        [locale]() {
          return i18n::LanguageManager::Get().GetCurrentLocale() == locale;
        });
  }
  menu_builder_.EndMenu();
}
 
// Menu state management
void MenuOrchestrator::ClearMenu() {
  menu_builder_.Clear();
}
 
void MenuOrchestrator::RefreshMenu() {
  menu_needs_refresh_ = true;
}
 
// Menu item callbacks - delegate to appropriate managers
void MenuOrchestrator::OnOpenRom() {
  // Delegate to EditorManager's LoadRom which handles session management
  if (editor_manager_) {
    auto status = editor_manager_->LoadRom();
    if (!status.ok()) {
      toast_manager_.Show(
          absl::StrFormat("Failed to load ROM: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnSaveRom() {
  // Delegate to EditorManager's SaveRom which handles editor data saving
  if (editor_manager_) {
    auto status = editor_manager_->SaveRom();
    if (!status.ok()) {
      if (absl::IsCancelled(status)) {
        return;
      }
      toast_manager_.Show(
          absl::StrFormat("Failed to save ROM: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnSaveRomAs() {
  popup_manager_.Show(PopupID::kSaveAs);
}
 
void MenuOrchestrator::OnCreateProject() {
  // Delegate to EditorManager which handles the full project creation flow
  if (editor_manager_) {
    auto status = editor_manager_->CreateNewProject();
    if (!status.ok()) {
      toast_manager_.Show(
          absl::StrFormat("Failed to create project: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnOpenProject() {
  // Delegate to EditorManager which handles ROM loading and session creation
  if (editor_manager_) {
    auto status = editor_manager_->OpenProject();
    if (!status.ok()) {
      toast_manager_.Show(
          absl::StrFormat("Failed to open project: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnSaveProject() {
  // Delegate to EditorManager which updates project with current state
  if (editor_manager_) {
    auto status = editor_manager_->SaveProject();
    if (!status.ok()) {
      toast_manager_.Show(
          absl::StrFormat("Failed to save project: %s", status.message()),
          ToastType::kError);
    } else {
      toast_manager_.Show("Project saved successfully", ToastType::kSuccess);
    }
  }
}
 
void MenuOrchestrator::OnSaveProjectAs() {
  // Delegate to EditorManager
  if (editor_manager_) {
    auto status = editor_manager_->SaveProjectAs();
    if (!status.ok()) {
      toast_manager_.Show(
          absl::StrFormat("Failed to save project as: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnShowProjectManagement() {
  // Show project management panel in right sidebar
  if (editor_manager_) {
    editor_manager_->ShowProjectManagement();
  }
}
 
void MenuOrchestrator::OnShowProjectFileEditor() {
  // Open the project file editor with the current project file
  if (editor_manager_) {
    editor_manager_->ShowProjectFileEditor();
  }
}
 
// Edit menu actions - delegate to current editor
void MenuOrchestrator::OnUndo() {
  if (editor_manager_) {
    auto* current_editor = editor_manager_->GetCurrentEditor();
    if (current_editor) {
      // Capture description before undo moves the action to the redo stack
      std::string desc = current_editor->GetUndoDescription();
      auto status = current_editor->Undo();
      if (status.ok()) {
        if (!desc.empty()) {
          toast_manager_.Show(absl::StrFormat("Undid: %s", desc),
                              ToastType::kInfo, 2.0f);
        }
      } else {
        toast_manager_.Show(
            absl::StrFormat("Undo failed: %s", status.message()),
            ToastType::kError);
      }
    }
  }
}
 
void MenuOrchestrator::OnRedo() {
  if (editor_manager_) {
    auto* current_editor = editor_manager_->GetCurrentEditor();
    if (current_editor) {
      // Capture description before redo moves the action to the undo stack
      std::string desc = current_editor->GetRedoDescription();
      auto status = current_editor->Redo();
      if (status.ok()) {
        if (!desc.empty()) {
          toast_manager_.Show(absl::StrFormat("Redid: %s", desc),
                              ToastType::kInfo, 2.0f);
        }
      } else {
        toast_manager_.Show(
            absl::StrFormat("Redo failed: %s", status.message()),
            ToastType::kError);
      }
    }
  }
}
 
void MenuOrchestrator::OnCut() {
  if (editor_manager_) {
    auto* current_editor = editor_manager_->GetCurrentEditor();
    if (current_editor) {
      auto status = current_editor->Cut();
      if (!status.ok()) {
        toast_manager_.Show(absl::StrFormat("Cut failed: %s", status.message()),
                            ToastType::kError);
      }
    }
  }
}
 
void MenuOrchestrator::OnCopy() {
  if (editor_manager_) {
    auto* current_editor = editor_manager_->GetCurrentEditor();
    if (current_editor) {
      auto status = current_editor->Copy();
      if (!status.ok()) {
        toast_manager_.Show(
            absl::StrFormat("Copy failed: %s", status.message()),
            ToastType::kError);
      }
    }
  }
}
 
void MenuOrchestrator::OnPaste() {
  if (editor_manager_) {
    auto* current_editor = editor_manager_->GetCurrentEditor();
    if (current_editor) {
      auto status = current_editor->Paste();
      if (!status.ok()) {
        toast_manager_.Show(
            absl::StrFormat("Paste failed: %s", status.message()),
            ToastType::kError);
      }
    }
  }
}
 
void MenuOrchestrator::OnFind() {
  if (editor_manager_) {
    auto* current_editor = editor_manager_->GetCurrentEditor();
    if (current_editor) {
      auto status = current_editor->Find();
      if (!status.ok()) {
        toast_manager_.Show(
            absl::StrFormat("Find failed: %s", status.message()),
            ToastType::kError);
      }
    }
  }
}
 
// Editor-specific menu actions
void MenuOrchestrator::OnSwitchToEditor(EditorType editor_type) {
  // Delegate to EditorManager which manages editor switching
  if (editor_manager_) {
    editor_manager_->SwitchToEditor(editor_type);
  }
}
 
void MenuOrchestrator::OnShowEditorSelection() {
  // Delegate to UICoordinator for editor selection dialog display
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->ShowEditorSelection();
    }
  }
}
 
void MenuOrchestrator::OnShowDisplaySettings() {
  popup_manager_.Show(PopupID::kDisplaySettings);
}
 
void MenuOrchestrator::OnShowHexEditor() {
  // Show hex editor window via WorkspaceWindowManager
  if (editor_manager_) {
    editor_manager_->window_manager().OpenWindow(
        editor_manager_->GetCurrentSessionId(), "Hex Editor");
  }
}
 
void MenuOrchestrator::OnShowPanelBrowser() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->SetWindowBrowserVisible(true);
    }
  }
}
 
void MenuOrchestrator::OnShowPanelFinder() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->ShowPanelFinder();
    }
  }
}
 
void MenuOrchestrator::OnShowWelcomeScreen() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->SetWelcomeScreenVisible(true);
    }
  }
}
 
#ifdef YAZE_BUILD_AGENT_UI
void MenuOrchestrator::OnShowAIAgent() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->SetAIAgentVisible(true);
    }
  }
}
 
void MenuOrchestrator::OnShowProposalDrawer() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->SetProposalDrawerVisible(true);
    }
  }
}
#endif
 
// Session management menu actions
void MenuOrchestrator::OnCreateNewSession() {
  session_coordinator_.CreateNewSession();
}
 
void MenuOrchestrator::OnDuplicateCurrentSession() {
  session_coordinator_.DuplicateCurrentSession();
}
 
void MenuOrchestrator::OnCloseCurrentSession() {
  if (editor_manager_) {
    editor_manager_->CloseCurrentSession();
  } else {
    session_coordinator_.CloseCurrentSession();
  }
}
 
void MenuOrchestrator::OnShowSessionSwitcher() {
  // Delegate to UICoordinator for session switcher UI
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->ShowSessionSwitcher();
    }
  }
}
 
void MenuOrchestrator::OnShowSessionManager() {
  popup_manager_.Show(PopupID::kSessionManager);
}
 
// Window management menu actions
void MenuOrchestrator::OnShowAllWindows() {
  // Delegate to EditorManager
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->ShowAllWindows();
    }
  }
}
 
void MenuOrchestrator::OnHideAllWindows() {
  // Delegate to EditorManager
  if (editor_manager_) {
    editor_manager_->HideAllWindows();
  }
}
 
void MenuOrchestrator::OnResetWorkspaceLayout() {
  // Queue as deferred action to avoid modifying ImGui state during menu rendering
  if (editor_manager_) {
    editor_manager_->QueueDeferredAction([this]() {
      editor_manager_->ResetWorkspaceLayout();
      toast_manager_.Show("Layout reset to default", ToastType::kInfo);
    });
  }
}
 
void MenuOrchestrator::OnSaveWorkspaceLayout() {
  // Delegate to EditorManager
  if (editor_manager_) {
    editor_manager_->SaveWorkspaceLayout();
  }
}
 
void MenuOrchestrator::OnLoadWorkspaceLayout() {
  // Delegate to EditorManager
  if (editor_manager_) {
    editor_manager_->LoadWorkspaceLayout();
  }
}
 
void MenuOrchestrator::OnShowLayoutPresets() {
  popup_manager_.Show(PopupID::kLayoutPresets);
}
 
void MenuOrchestrator::OnShowLayoutDesigner() {
  WorkspaceWindowManager* manager = window_manager_;
  if (manager == nullptr && editor_manager_ != nullptr) {
    manager = &editor_manager_->window_manager();
  }
  if (manager == nullptr) {
    toast_manager_.Show("Layout Designer unavailable: no window manager",
                        ToastType::kError);
    return;
  }
 
  const size_t session_id = session_coordinator_.GetActiveSessionId();
  if (manager->GetActiveCategory().empty() ||
      manager->GetActiveCategory() ==
          WorkspaceWindowManager::kDashboardCategory) {
    manager->SetActiveCategory("Settings");
  }
 
  const bool already_open =
      manager->IsWindowOpen(session_id, kLayoutDesignerWindowId);
  if (!already_open &&
      !manager->OpenWindow(session_id, kLayoutDesignerWindowId)) {
    toast_manager_.Show(
        "Layout Designer is not registered in the active session",
        ToastType::kError);
    return;
  }
 
  // Cross-editor Settings-category panels are only drawn from another editor
  // when pinned. Opening the designer from the menubar should make it visible
  // immediately instead of merely flipping an off-category visibility flag.
  manager->SetWindowPinned(session_id, kLayoutDesignerWindowId, true);
}
 
void MenuOrchestrator::OnLoadDeveloperLayout() {
  if (editor_manager_) {
    editor_manager_->ApplyLayoutPreset("Developer");
  }
}
 
void MenuOrchestrator::OnLoadDesignerLayout() {
  if (editor_manager_) {
    editor_manager_->ApplyLayoutPreset("Designer");
  }
}
 
void MenuOrchestrator::OnLoadModderLayout() {
  if (editor_manager_) {
    editor_manager_->ApplyLayoutPreset("Modder");
  }
}
 
// Tool menu actions
void MenuOrchestrator::OnShowGlobalSearch() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->ShowGlobalSearch();
    }
  }
}
 
void MenuOrchestrator::OnShowCommandPalette() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->ShowCommandPalette();
    }
  }
}
 
void MenuOrchestrator::OnShowPerformanceDashboard() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->SetPerformanceDashboardVisible(true);
    }
  }
}
 
void MenuOrchestrator::OnShowImGuiDemo() {
  if (editor_manager_) {
    editor_manager_->ShowImGuiDemo();
  }
}
 
void MenuOrchestrator::OnShowImGuiMetrics() {
  if (editor_manager_) {
    editor_manager_->ShowImGuiMetrics();
  }
}
 
void MenuOrchestrator::OnShowMemoryEditor() {
  if (editor_manager_) {
    editor_manager_->window_manager().OpenWindow(
        editor_manager_->GetCurrentSessionId(), "Memory Editor");
  }
}
 
void MenuOrchestrator::OnShowResourceLabelManager() {
  if (editor_manager_) {
    if (auto* ui = editor_manager_->ui_coordinator()) {
      ui->SetResourceLabelManagerVisible(true);
    }
  }
}
 
#ifdef YAZE_ENABLE_TESTING
void MenuOrchestrator::OnShowTestDashboard() {
  if (editor_manager_) {
    editor_manager_->ShowTestDashboard();
  }
}
 
void MenuOrchestrator::OnRunAllTests() {
  toast_manager_.Show("Running all tests...", ToastType::kInfo);
  // TODO: Implement test runner integration
}
 
void MenuOrchestrator::OnRunUnitTests() {
  toast_manager_.Show("Running unit tests...", ToastType::kInfo);
  // TODO: Implement unit test runner
}
 
void MenuOrchestrator::OnRunIntegrationTests() {
  toast_manager_.Show("Running integration tests...", ToastType::kInfo);
  // TODO: Implement integration test runner
}
 
void MenuOrchestrator::OnRunE2ETests() {
  toast_manager_.Show(
      "E2E runner is not wired in-app yet. Use scripts/agents/run-tests.sh or "
      "z3ed test-run.",
      ToastType::kWarning);
}
#endif
 
#ifdef YAZE_WITH_GRPC
void MenuOrchestrator::OnStartCollaboration() {
  toast_manager_.Show(
      "Collaboration session start is not wired yet. Run yaze-server and use "
      "the web client for live sync.",
      ToastType::kWarning);
}
 
void MenuOrchestrator::OnJoinCollaboration() {
  toast_manager_.Show(
      "Join collaboration is not wired yet. Use the web client + yaze-server.",
      ToastType::kWarning);
}
 
void MenuOrchestrator::OnShowNetworkStatus() {
  toast_manager_.Show("Network status panel is not implemented yet.",
                      ToastType::kWarning);
}
#endif
 
// Help menu actions
void MenuOrchestrator::OnShowAbout() {
  popup_manager_.Show(PopupID::kAbout);
}
 
void MenuOrchestrator::OnShowGettingStarted() {
  popup_manager_.Show(PopupID::kGettingStarted);
}
 
void MenuOrchestrator::OnShowBuildInstructions() {
  popup_manager_.Show(PopupID::kBuildInstructions);
}
 
void MenuOrchestrator::OnShowCLIUsage() {
  popup_manager_.Show(PopupID::kCLIUsage);
}
 
void MenuOrchestrator::OnShowTroubleshooting() {
  popup_manager_.Show(PopupID::kTroubleshooting);
}
 
void MenuOrchestrator::OnShowContributing() {
  popup_manager_.Show(PopupID::kContributing);
}
 
void MenuOrchestrator::OnShowWhatsNew() {
  popup_manager_.Show(PopupID::kWhatsNew);
}
 
void MenuOrchestrator::OnShowSupportedFeatures() {
  popup_manager_.Show(PopupID::kSupportedFeatures);
}
 
// Additional File menu actions
void MenuOrchestrator::OnShowRomInfo() {
  popup_manager_.Show(PopupID::kRomInfo);
}
 
void MenuOrchestrator::OnCreateBackup() {
  if (editor_manager_) {
    auto status = rom_manager_.CreateBackup(editor_manager_->GetCurrentRom());
    if (status.ok()) {
      toast_manager_.Show("Backup created successfully", ToastType::kSuccess);
    } else {
      toast_manager_.Show(
          absl::StrFormat("Backup failed: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnValidateRom() {
  if (editor_manager_) {
    auto status = rom_manager_.ValidateRom(editor_manager_->GetCurrentRom());
    if (status.ok()) {
      toast_manager_.Show("ROM validation passed", ToastType::kSuccess);
    } else {
      toast_manager_.Show(
          absl::StrFormat("ROM validation failed: %s", status.message()),
          ToastType::kError);
    }
  }
}
 
void MenuOrchestrator::OnShowSettings() {
  // Activate settings editor
  if (editor_manager_) {
    editor_manager_->SwitchToEditor(EditorType::kSettings);
  }
}
 
void MenuOrchestrator::OnQuit() {
  if (editor_manager_) {
    editor_manager_->Quit();
  }
}
 
// Menu item validation helpers
bool MenuOrchestrator::CanSaveRom() const {
  auto* rom = editor_manager_ ? editor_manager_->GetCurrentRom() : nullptr;
  return rom ? rom_manager_.IsRomLoaded(rom) : false;
}
 
bool MenuOrchestrator::CanSaveProject() const {
  return project_manager_.HasActiveProject();
}
 
bool MenuOrchestrator::HasActiveRom() const {
  auto* rom = editor_manager_ ? editor_manager_->GetCurrentRom() : nullptr;
  return rom ? rom_manager_.IsRomLoaded(rom) : false;
}
 
bool MenuOrchestrator::HasActiveProject() const {
  return project_manager_.HasActiveProject();
}
 
bool MenuOrchestrator::HasProjectFile() const {
  // Check if EditorManager has a project with a valid filepath
  // This is separate from HasActiveProject which checks ProjectManager
  const auto* project =
      editor_manager_ ? editor_manager_->GetCurrentProject() : nullptr;
  return project && !project->filepath.empty();
}
 
bool MenuOrchestrator::HasCurrentEditor() const {
  return editor_manager_ && editor_manager_->GetCurrentEditor() != nullptr;
}
 
bool MenuOrchestrator::HasMultipleSessions() const {
  return session_coordinator_.HasMultipleSessions();
}
 
// Menu item text generation
std::string MenuOrchestrator::GetRomFilename() const {
  auto* rom = editor_manager_ ? editor_manager_->GetCurrentRom() : nullptr;
  return rom ? rom_manager_.GetRomFilename(rom) : "";
}
 
std::string MenuOrchestrator::GetProjectName() const {
  return project_manager_.GetProjectName();
}
 
std::string MenuOrchestrator::GetCurrentEditorName() const {
  // TODO: Get current editor name
  return "Unknown Editor";
}
 
// Shortcut key management
std::string MenuOrchestrator::GetShortcutForAction(
    const std::string& action) const {
  // TODO: Implement shortcut mapping
  return "";
}
 
void MenuOrchestrator::RegisterGlobalShortcuts() {
  // TODO: Register global keyboard shortcuts
}
 
// ============================================================================
// Debug Menu Actions
// ============================================================================
 
void MenuOrchestrator::OnRunDataIntegrityCheck() {
#ifdef YAZE_ENABLE_TESTING
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  toast_manager_.Show("Running ROM integrity tests...", ToastType::kInfo);
  // This would integrate with the test system in master
  // For now, just show a placeholder
  toast_manager_.Show("Data integrity check completed", ToastType::kSuccess,
                      3.0f);
#else
  toast_manager_.Show("Testing not enabled in this build", ToastType::kWarning);
#endif
}
 
void MenuOrchestrator::OnTestSaveLoad() {
#ifdef YAZE_ENABLE_TESTING
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  toast_manager_.Show("Running ROM save/load tests...", ToastType::kInfo);
  // This would integrate with the test system in master
  toast_manager_.Show("Save/load test completed", ToastType::kSuccess, 3.0f);
#else
  toast_manager_.Show("Testing not enabled in this build", ToastType::kWarning);
#endif
}
 
void MenuOrchestrator::OnCheckRomVersion() {
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  // Check ZSCustomOverworld version
  uint8_t version = (*rom)[zelda3::OverworldCustomASMHasBeenApplied];
  std::string version_str =
      (version == 0xFF) ? "Vanilla" : absl::StrFormat("v%d", version);
 
  toast_manager_.Show(
      absl::StrFormat("ROM: %s | ZSCustomOverworld: %s", rom->title().c_str(),
                      version_str.c_str()),
      ToastType::kInfo, 5.0f);
}
 
void MenuOrchestrator::OnUpgradeRom() {
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  toast_manager_.Show("Use Overworld Editor to upgrade ROM version",
                      ToastType::kInfo, 4.0f);
}
 
void MenuOrchestrator::OnToggleCustomLoading() {
  auto& flags = core::FeatureFlags::get();
  flags.overworld.kLoadCustomOverworld = !flags.overworld.kLoadCustomOverworld;
 
  toast_manager_.Show(
      absl::StrFormat(
          "Custom Overworld Loading: %s",
          flags.overworld.kLoadCustomOverworld ? "Enabled" : "Disabled"),
      ToastType::kInfo);
}
 
void MenuOrchestrator::OnToggleAsarPatch() {
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  auto& flags = core::FeatureFlags::get();
  flags.overworld.kApplyZSCustomOverworldASM =
      !flags.overworld.kApplyZSCustomOverworldASM;
 
  toast_manager_.Show(
      absl::StrFormat(
          "ZSCustomOverworld ASM Application: %s",
          flags.overworld.kApplyZSCustomOverworldASM ? "Enabled" : "Disabled"),
      ToastType::kInfo);
}
 
void MenuOrchestrator::OnLoadAsmFile() {
  toast_manager_.Show("ASM file loading not yet implemented",
                      ToastType::kWarning);
}
 
void MenuOrchestrator::OnShowAssemblyEditor() {
  if (editor_manager_) {
    editor_manager_->SwitchToEditor(EditorType::kAssembly);
  }
}
 
void MenuOrchestrator::OnExportBpsPatch() {
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  // Ask user to select the original/clean ROM to diff against
  auto options = util::MakeRomFileDialogOptions();
  std::string original_path =
      util::FileDialogWrapper::ShowOpenFileDialog(options);
  if (original_path.empty()) {
    return;  // User cancelled
  }
 
  // Load the original ROM
  Rom original_rom;
  auto load_status = original_rom.LoadFromFile(original_path);
  if (!load_status.ok()) {
    toast_manager_.Show(absl::StrFormat("Failed to load original ROM: %s",
                                        load_status.message()),
                        ToastType::kError);
    return;
  }
 
  // Generate BPS patch
  std::vector<uint8_t> patch_data;
  auto create_status =
      util::CreateBpsPatch(original_rom.vector(), rom->vector(), patch_data);
  if (!create_status.ok()) {
    toast_manager_.Show(absl::StrFormat("Failed to create BPS patch: %s",
                                        create_status.message()),
                        ToastType::kError);
    return;
  }
 
  // Ask user where to save the patch
  std::string default_name = rom->short_name() + ".bps";
  std::string save_path =
      util::FileDialogWrapper::ShowSaveFileDialog(default_name, "bps");
  if (save_path.empty()) {
    return;  // User cancelled
  }
 
  // Ensure .bps extension
  if (save_path.size() < 4 ||
      save_path.substr(save_path.size() - 4) != ".bps") {
    save_path += ".bps";
  }
 
  // Write the patch file
  std::ofstream file(save_path, std::ios::binary);
  if (!file.is_open()) {
    toast_manager_.Show(
        absl::StrFormat("Failed to open file for writing: %s", save_path),
        ToastType::kError);
    return;
  }
 
  file.write(reinterpret_cast<const char*>(patch_data.data()),
             patch_data.size());
  file.close();
 
  if (file.fail()) {
    toast_manager_.Show(
        absl::StrFormat("Failed to write patch file: %s", save_path),
        ToastType::kError);
    return;
  }
 
  toast_manager_.Show(absl::StrFormat("BPS patch exported: %s (%zu bytes)",
                                      save_path, patch_data.size()),
                      ToastType::kSuccess);
}
 
void MenuOrchestrator::OnApplyBpsPatch() {
  if (!editor_manager_)
    return;
  auto* rom = editor_manager_->GetCurrentRom();
  if (!rom || !rom->is_loaded())
    return;
 
  // Ask user to select a .bps file
  util::FileDialogOptions options;
  options.filters.push_back({"BPS Patch", "bps"});
  std::string patch_path = util::FileDialogWrapper::ShowOpenFileDialog(options);
  if (patch_path.empty()) {
    return;  // User cancelled
  }
 
  // Read the patch file
  std::ifstream file(patch_path, std::ios::binary);
  if (!file.is_open()) {
    toast_manager_.Show(
        absl::StrFormat("Failed to open patch file: %s", patch_path),
        ToastType::kError);
    return;
  }
 
  std::vector<uint8_t> patch_data((std::istreambuf_iterator<char>(file)),
                                  std::istreambuf_iterator<char>());
  file.close();
 
  if (patch_data.empty()) {
    toast_manager_.Show("Patch file is empty", ToastType::kError);
    return;
  }
 
  // Apply the patch
  std::vector<uint8_t> patched_rom;
  auto apply_status =
      util::ApplyBpsPatch(rom->vector(), patch_data, patched_rom);
  if (!apply_status.ok()) {
    toast_manager_.Show(absl::StrFormat("Failed to apply BPS patch: %s",
                                        apply_status.message()),
                        ToastType::kError);
    return;
  }
 
  // Load the patched data into the ROM
  auto load_status = rom->LoadFromData(patched_rom);
  if (!load_status.ok()) {
    toast_manager_.Show(absl::StrFormat("Failed to load patched ROM data: %s",
                                        load_status.message()),
                        ToastType::kError);
    return;
  }
 
  rom->set_dirty(true);
  toast_manager_.Show("BPS patch applied successfully", ToastType::kSuccess);
}
 
}  // namespace editor
}  // namespace yaze