arena.cc

Go to the documentation of this file.

#include "app/gfx/resource/arena.h"
 
#include "app/platform/sdl_compat.h"
 
#include <algorithm>
#include <chrono>
 
#include "absl/strings/str_format.h"
#include "app/gfx/backend/irenderer.h"
#include "util/log.h"
#include "util/sdl_deleter.h"
#include "zelda3/dungeon/palette_debug.h"
 
namespace yaze {
namespace gfx {
 
void Arena::Initialize(IRenderer* renderer) {
  renderer_ = renderer;
  if (renderer != nullptr) {
    is_shutdown_ = false;
  }
}
 
Arena& Arena::Get() {
  static Arena instance;
  return instance;
}
 
Arena::Arena() : bg1_(512, 512), bg2_(512, 512) {
  layer1_buffer_.fill(0);
  layer2_buffer_.fill(0);
}
 
Arena::~Arena() {
  // Use the safe shutdown method that handles cleanup properly
  Shutdown();
}
 
void Arena::QueueTextureCommand(TextureCommandType type, Bitmap* bitmap) {
  // Store generation at queue time for staleness detection
  uint32_t gen = bitmap ? bitmap->generation() : 0;
  texture_command_queue_.push_back({type, bitmap, gen});
}
 
bool Arena::HasPendingTextureCommand(TextureCommandType type,
                                     const Bitmap* bitmap) const {
  if (bitmap == nullptr) {
    return false;
  }
  const uint32_t generation = bitmap->generation();
  return std::any_of(
      texture_command_queue_.begin(), texture_command_queue_.end(),
      [type, bitmap, generation](const TextureCommand& command) {
        return command.type == type && command.bitmap == bitmap &&
               command.generation == generation;
      });
}
 
void Arena::ClearTextureQueue() {
  texture_command_queue_.clear();
}
 
void Arena::RetireBitmap(Bitmap& bitmap) {
  // Texture commands retain Bitmap addresses. Remove them while the owner is
  // still alive so no later generation check dereferences freed memory.
  std::erase_if(texture_command_queue_,
                [&bitmap](const TextureCommand& command) {
                  return command.bitmap == &bitmap;
                });
 
  const TextureHandle texture = bitmap.texture();
  if (!is_shutdown_ && texture != nullptr &&
      std::find(retired_texture_handles_.begin(),
                retired_texture_handles_.end(),
                texture) == retired_texture_handles_.end()) {
    retired_texture_handles_.push_back(texture);
  }
 
  // Detach before returning the surface so a second retirement is a no-op and
  // the soon-to-be-destroyed Bitmap no longer advertises live resources.
  SDL_Surface* surface = bitmap.DetachSurfaceForArena();
  (void)bitmap.DetachTextureForArena();
  bitmap.MarkRetiredByArena();
  // Shutdown clears the tracked surfaces before editor-owned Bitmap objects
  // are destroyed. Do not return a stale pointer to the pool in that case.
  if (surface != nullptr && surfaces_.contains(surface)) {
    FreeSurface(surface);
  }
}
 
size_t Arena::DrainRetiredBitmaps(IRenderer* renderer) {
  IRenderer* active_renderer = renderer ? renderer : renderer_;
  if (active_renderer == nullptr) {
    return 0;
  }
 
  size_t destroyed = 0;
  auto it = retired_texture_handles_.begin();
  while (it != retired_texture_handles_.end()) {
    try {
      active_renderer->DestroyTexture(*it);
      it = retired_texture_handles_.erase(it);
      ++destroyed;
    } catch (...) {
      LOG_ERROR("Arena", "Exception destroying retired bitmap texture");
      ++it;
    }
  }
  return destroyed;
}
 
bool Arena::ProcessSingleTexture(IRenderer* renderer) {
  IRenderer* active_renderer = renderer ? renderer : renderer_;
  if (!active_renderer || texture_command_queue_.empty()) {
    return false;
  }
 
  auto it = texture_command_queue_.begin();
  const auto& command = *it;
  bool processed = false;
  bool should_remove = true;
 
  // Skip stale commands where bitmap was reallocated since queuing
  if (command.bitmap && command.bitmap->generation() != command.generation) {
    LOG_DEBUG("Arena", "Skipping stale texture command (gen %u != %u)",
              command.generation, command.bitmap->generation());
    texture_command_queue_.erase(it);
    return false;
  }
 
  switch (command.type) {
    case TextureCommandType::CREATE: {
      if (command.bitmap && command.bitmap->surface() &&
          command.bitmap->surface()->format && command.bitmap->is_active() &&
          command.bitmap->width() > 0 && command.bitmap->height() > 0) {
        const auto old_texture = command.bitmap->texture();
        TextureHandle replacement = nullptr;
        try {
          replacement = active_renderer->CreateTexture(
              command.bitmap->width(), command.bitmap->height());
        } catch (...) {
          LOG_ERROR("Arena", "Exception during single texture creation");
          should_remove = false;
          break;
        }
        if (!replacement) {
          should_remove = false;
          break;
        }
        try {
          active_renderer->UpdateTexture(replacement, *command.bitmap);
        } catch (...) {
          LOG_ERROR("Arena", "Exception updating new single texture");
          if (replacement != old_texture) {
            try {
              active_renderer->DestroyTexture(replacement);
            } catch (...) {
              LOG_ERROR("Arena", "Exception cleaning up failed single texture");
            }
          }
          should_remove = false;
          break;
        }
 
        command.bitmap->set_texture(replacement);
        if (old_texture && old_texture != replacement) {
          try {
            active_renderer->DestroyTexture(old_texture);
          } catch (...) {
            LOG_ERROR("Arena", "Exception destroying replaced single texture");
          }
        }
        processed = true;
      }
      break;
    }
    case TextureCommandType::UPDATE: {
      if (command.bitmap && command.bitmap->texture() &&
          command.bitmap->surface() && command.bitmap->surface()->format &&
          command.bitmap->is_active()) {
        try {
          active_renderer->UpdateTexture(command.bitmap->texture(),
                                         *command.bitmap);
          processed = true;
        } catch (...) {
          LOG_ERROR("Arena", "Exception during single texture update");
        }
      }
      break;
    }
    case TextureCommandType::DESTROY: {
      if (command.bitmap && command.bitmap->texture()) {
        try {
          active_renderer->DestroyTexture(command.bitmap->texture());
          command.bitmap->set_texture(nullptr);
          processed = true;
        } catch (...) {
          LOG_ERROR("Arena", "Exception during single texture destruction");
        }
      }
      break;
    }
  }
 
  if (should_remove) {
    texture_command_queue_.erase(it);
  }
  return processed;
}
 
void Arena::ProcessTextureQueue(IRenderer* renderer) {
  // Use provided renderer if available, otherwise use stored renderer
  IRenderer* active_renderer = renderer ? renderer : renderer_;
 
  if (!active_renderer) {
    // Arena not initialized yet - defer processing
    return;
  }
 
  if (texture_command_queue_.empty()) {
    return;
  }
 
  // Performance optimization: Batch process textures with limits
  // Process up to 8 texture operations per frame to avoid frame drops
  constexpr size_t kMaxTexturesPerFrame = 8;
  size_t processed = 0;
 
  auto it = texture_command_queue_.begin();
  while (it != texture_command_queue_.end() &&
         processed < kMaxTexturesPerFrame) {
    const auto& command = *it;
    bool should_remove = true;
 
    // Skip stale commands where bitmap was reallocated since queuing
    if (command.bitmap && command.bitmap->generation() != command.generation) {
      LOG_DEBUG("Arena", "Skipping stale texture command (gen %u != %u)",
                command.generation, command.bitmap->generation());
      it = texture_command_queue_.erase(it);
      continue;
    }
 
    // CRITICAL: Replicate the exact short-circuit evaluation from working code
    // We MUST check command.bitmap AND command.bitmap->surface() in one
    // expression to avoid dereferencing invalid pointers
 
    switch (command.type) {
      case TextureCommandType::CREATE: {
        // Create a new texture and update it with bitmap data
        // Use short-circuit evaluation - if bitmap is invalid, never call
        // ->surface()
        if (command.bitmap && command.bitmap->surface() &&
            command.bitmap->is_active() && command.bitmap->width() > 0 &&
            command.bitmap->height() > 0) {
 
          // DEBUG: Log texture creation with palette validation
          auto* surf = command.bitmap->surface();
          SDL_Palette* palette = platform::GetSurfacePalette(surf);
          bool has_palette = palette != nullptr;
          int color_count = has_palette ? palette->ncolors : 0;
 
          // Log detailed surface state for debugging
          zelda3::PaletteDebugger::Get().LogSurfaceState(
              "Arena::ProcessTextureQueue (CREATE)", surf);
          zelda3::PaletteDebugger::Get().LogTextureCreation(
              "Arena::ProcessTextureQueue", has_palette, color_count);
 
          // WARNING: Creating texture without proper palette will produce wrong
          // colors
          if (!has_palette) {
            LOG_WARN("Arena",
                     "Creating texture from surface WITHOUT palette - "
                     "colors will be incorrect!");
            zelda3::PaletteDebugger::Get().LogPaletteApplication(
                "Arena::ProcessTextureQueue", 0, false,
                "Surface has NO palette");
          } else if (color_count < 90) {
            LOG_WARN("Arena",
                     "Creating texture with only %d palette colors (expected "
                     "90 for dungeon)",
                     color_count);
            zelda3::PaletteDebugger::Get().LogPaletteApplication(
                "Arena::ProcessTextureQueue", 0, false,
                absl::StrFormat("Low color count: %d", color_count));
          }
 
          zelda3::PaletteDebugger::Get().LogPaletteApplication(
              "Arena::ProcessTextureQueue", 0, true,
              "Calling CreateTexture...");
          const auto old_texture = command.bitmap->texture();
          TextureHandle replacement = nullptr;
          try {
            replacement = active_renderer->CreateTexture(
                command.bitmap->width(), command.bitmap->height());
          } catch (...) {
            LOG_ERROR("Arena", "Exception during texture creation");
            zelda3::PaletteDebugger::Get().LogPaletteApplication(
                "Arena::ProcessTextureQueue", 0, false,
                "EXCEPTION during texture creation");
            should_remove = false;
            break;
          }
 
          if (!replacement) {
            zelda3::PaletteDebugger::Get().LogPaletteApplication(
                "Arena::ProcessTextureQueue", 0, false,
                "CreateTexture returned NULL");
            should_remove = false;
            break;
          }
 
          try {
            active_renderer->UpdateTexture(replacement, *command.bitmap);
          } catch (...) {
            LOG_ERROR("Arena", "Exception updating new texture");
            if (replacement != old_texture) {
              try {
                active_renderer->DestroyTexture(replacement);
              } catch (...) {
                LOG_ERROR("Arena", "Exception cleaning up failed texture");
              }
            }
            should_remove = false;
            break;
          }
 
          command.bitmap->set_texture(replacement);
          if (old_texture && old_texture != replacement) {
            try {
              active_renderer->DestroyTexture(old_texture);
            } catch (...) {
              LOG_ERROR("Arena", "Exception destroying replaced texture");
            }
          }
          zelda3::PaletteDebugger::Get().LogPaletteApplication(
              "Arena::ProcessTextureQueue", 0, true, "CreateTexture SUCCESS");
          processed++;
        }
        break;
      }
      case TextureCommandType::UPDATE: {
        // Update existing texture with current bitmap data
        if (command.bitmap && command.bitmap->texture() &&
            command.bitmap->surface() && command.bitmap->surface()->format &&
            command.bitmap->is_active()) {
          try {
            active_renderer->UpdateTexture(command.bitmap->texture(),
                                           *command.bitmap);
            processed++;
          } catch (...) {
            LOG_ERROR("Arena", "Exception during texture update");
          }
        }
        break;
      }
      case TextureCommandType::DESTROY: {
        if (command.bitmap && command.bitmap->texture()) {
          try {
            active_renderer->DestroyTexture(command.bitmap->texture());
            command.bitmap->set_texture(nullptr);
            processed++;
          } catch (...) {
            LOG_ERROR("Arena", "Exception during texture destruction");
          }
        }
        break;
      }
    }
 
    if (should_remove) {
      it = texture_command_queue_.erase(it);
    } else {
      ++it;
    }
  }
}
 
bool Arena::ProcessTextureQueueWithBudget(IRenderer* renderer,
                                          float budget_ms) {
  using Clock = std::chrono::high_resolution_clock;
  using Microseconds = std::chrono::microseconds;
 
  IRenderer* active_renderer = renderer ? renderer : renderer_;
  if (!active_renderer) {
    return texture_command_queue_.empty();
  }
 
  if (texture_command_queue_.empty()) {
    return true;  // Queue is empty, all done
  }
 
  // Convert budget to microseconds for precise timing
  const auto budget_us = static_cast<long long>(budget_ms * 1000.0f);
  const auto start_time = Clock::now();
 
  size_t textures_this_call = 0;
 
  // Process textures until budget exhausted or queue empty
  while (!texture_command_queue_.empty()) {
    // Check time budget before each texture (not after, to avoid overshoot)
    if (textures_this_call > 0) {  // Always process at least one
      auto elapsed =
          std::chrono::duration_cast<Microseconds>(Clock::now() - start_time);
      if (elapsed.count() >= budget_us) {
        LOG_DEBUG("Arena",
                  "Budget exhausted: processed %zu textures in %.2fms, "
                  "%zu remaining",
                  textures_this_call, elapsed.count() / 1000.0f,
                  texture_command_queue_.size());
        break;
      }
    }
 
    // A failed CREATE remains queued for a later frame. Stop this budget pass
    // when no command was removed so a retry cannot spin on the same front
    // entry indefinitely.
    const size_t queue_size_before = texture_command_queue_.size();
    if (ProcessSingleTexture(active_renderer)) {
      textures_this_call++;
    } else if (texture_command_queue_.size() == queue_size_before) {
      break;
    }
  }
 
  // Update statistics
  if (textures_this_call > 0) {
    auto total_elapsed =
        std::chrono::duration_cast<Microseconds>(Clock::now() - start_time);
    float elapsed_ms = total_elapsed.count() / 1000.0f;
 
    texture_queue_stats_.textures_processed += textures_this_call;
    texture_queue_stats_.frames_with_work++;
    texture_queue_stats_.total_time_ms += elapsed_ms;
 
    if (elapsed_ms > texture_queue_stats_.max_frame_time_ms) {
      texture_queue_stats_.max_frame_time_ms = elapsed_ms;
    }
 
    if (texture_queue_stats_.textures_processed > 0) {
      texture_queue_stats_.avg_texture_time_ms =
          texture_queue_stats_.total_time_ms /
          static_cast<float>(texture_queue_stats_.textures_processed);
    }
  }
 
  return texture_command_queue_.empty();
}
 
SDL_Surface* Arena::AllocateSurface(int width, int height, int depth,
                                    int format) {
  // Try to get a surface from the pool first
  for (auto it = surface_pool_.available_surfaces_.begin();
       it != surface_pool_.available_surfaces_.end(); ++it) {
    auto& info = surface_pool_.surface_info_[*it];
    if (std::get<0>(info) == width && std::get<1>(info) == height &&
        std::get<2>(info) == depth && std::get<3>(info) == format) {
      SDL_Surface* surface = *it;
      surface_pool_.available_surfaces_.erase(it);
      return surface;
    }
  }
 
  // Create new surface if none available in pool
  Uint32 sdl_format = GetSnesPixelFormat(format);
  SDL_Surface* surface =
      platform::CreateSurface(width, height, depth, sdl_format);
 
  if (surface) {
    auto surface_ptr =
        std::unique_ptr<SDL_Surface, util::SDL_Surface_Deleter>(surface);
    surfaces_[surface] = std::move(surface_ptr);
    surface_pool_.surface_info_[surface] =
        std::make_tuple(width, height, depth, format);
  }
 
  return surface;
}
 
void Arena::FreeSurface(SDL_Surface* surface) {
  if (!surface)
    return;
 
  // Return surface to pool if space available
  if (surface_pool_.available_surfaces_.size() < surface_pool_.MAX_POOL_SIZE) {
    surface_pool_.available_surfaces_.push_back(surface);
  } else {
    // Remove from tracking maps
    surface_pool_.surface_info_.erase(surface);
    surfaces_.erase(surface);
  }
}
 
void Arena::Shutdown() {
  if (is_shutdown_) {
    return;
  }
 
  // Process any remaining batch updates before shutdown
  ProcessTextureQueue(renderer_);
  DrainRetiredBitmaps(renderer_);
 
  // Editor-owned Bitmap objects can outlive the renderer and window backend.
  // Late retirement must only detach their stale resource fields.
  is_shutdown_ = true;
 
  // Clear LRU cache tracking (doesn't destroy textures, just tracking)
  ClearSheetCache();
 
  // Clear pool references first to prevent reuse during shutdown
  surface_pool_.available_surfaces_.clear();
  surface_pool_.surface_info_.clear();
  texture_pool_.available_textures_.clear();
  texture_pool_.texture_sizes_.clear();
 
  // CRITICAL FIX: Clear containers in reverse order to prevent cleanup issues
  // This ensures that dependent resources are freed before their dependencies
  textures_.clear();
  surfaces_.clear();
 
  // Clear any remaining queue items
  texture_command_queue_.clear();
  retired_texture_handles_.clear();
  renderer_ = nullptr;
}
 
void Arena::NotifySheetModified(int sheet_index) {
  if (sheet_index < 0 || sheet_index >= 223) {
    LOG_WARN("Arena", "Invalid sheet index %d, ignoring notification",
             sheet_index);
    return;
  }
 
  auto& sheet = gfx_sheets_[sheet_index];
  if (!sheet.is_active() || !sheet.surface()) {
    LOG_DEBUG("Arena",
              "Sheet %d not active or no surface, skipping notification",
              sheet_index);
    return;
  }
 
  // Queue texture update so changes are visible in all editors
  if (sheet.texture()) {
    QueueTextureCommand(TextureCommandType::UPDATE, &sheet);
    LOG_DEBUG("Arena", "Queued texture update for modified sheet %d",
              sheet_index);
  } else {
    // Create texture if it doesn't exist
    QueueTextureCommand(TextureCommandType::CREATE, &sheet);
    LOG_DEBUG("Arena", "Queued texture creation for modified sheet %d",
              sheet_index);
  }
}
 
// ========== Palette Change Notification System ==========
 
void Arena::NotifyPaletteModified(const std::string& group_name,
                                  int palette_index) {
  LOG_DEBUG("Arena", "Palette modified: group='%s', palette=%d",
            group_name.c_str(), palette_index);
 
  // Notify all registered listeners
  for (const auto& [id, callback] : palette_listeners_) {
    try {
      callback(group_name, palette_index);
    } catch (const std::exception& e) {
      LOG_ERROR("Arena", "Exception in palette listener %d: %s", id, e.what());
    }
  }
 
  LOG_DEBUG("Arena", "Notified %zu palette listeners",
            palette_listeners_.size());
}
 
int Arena::RegisterPaletteListener(PaletteChangeCallback callback) {
  int id = next_palette_listener_id_++;
  palette_listeners_[id] = std::move(callback);
  LOG_DEBUG("Arena", "Registered palette listener with ID %d", id);
  return id;
}
 
void Arena::UnregisterPaletteListener(int listener_id) {
  auto it = palette_listeners_.find(listener_id);
  if (it != palette_listeners_.end()) {
    palette_listeners_.erase(it);
    LOG_DEBUG("Arena", "Unregistered palette listener with ID %d", listener_id);
  }
}
 
// ========== LRU Sheet Texture Cache ==========
 
void Arena::TouchSheet(int sheet_index) {
  if (sheet_index < 0 || sheet_index >= 223) {
    return;
  }
 
  auto map_it = sheet_lru_map_.find(sheet_index);
  if (map_it != sheet_lru_map_.end()) {
    // Sheet already in cache - move to front (most recently used)
    sheet_lru_list_.erase(map_it->second);
    sheet_lru_list_.push_front(sheet_index);
    map_it->second = sheet_lru_list_.begin();
  } else {
    // New sheet - add to front
    sheet_lru_list_.push_front(sheet_index);
    sheet_lru_map_[sheet_index] = sheet_lru_list_.begin();
  }
}
 
Bitmap* Arena::GetSheetWithCache(int sheet_index) {
  if (sheet_index < 0 || sheet_index >= 223) {
    return nullptr;
  }
 
  auto& sheet = gfx_sheets_[sheet_index];
 
  // Check if sheet already has texture (cache hit)
  bool had_texture = sheet.texture() != nullptr;
 
  // Touch to update LRU order
  TouchSheet(sheet_index);
 
  if (had_texture) {
    sheet_cache_stats_.hits++;
  } else {
    sheet_cache_stats_.misses++;
 
    // Queue texture creation if sheet has valid surface
    if (sheet.is_active() && sheet.surface()) {
      QueueTextureCommand(TextureCommandType::CREATE, &sheet);
    }
 
    // Check if we need to evict LRU sheets
    if (sheet_lru_map_.size() > sheet_cache_max_size_) {
      EvictLRUSheets(0);  // Evict until under max
    }
  }
 
  sheet_cache_stats_.current_size = sheet_lru_map_.size();
  return &sheet;
}
 
void Arena::SetSheetCacheSize(size_t max_size) {
  // Clamp to valid range
  sheet_cache_max_size_ = std::clamp(max_size, size_t{16}, size_t{223});
 
  // Evict if current cache exceeds new size
  if (sheet_lru_map_.size() > sheet_cache_max_size_) {
    EvictLRUSheets(0);
  }
 
  LOG_INFO("Arena", "Sheet cache size set to %zu", sheet_cache_max_size_);
}
 
size_t Arena::EvictLRUSheets(size_t count) {
  size_t evicted = 0;
  size_t target_evictions = count;
 
  // If count is 0, evict until we're under the max size
  if (count == 0 && sheet_lru_map_.size() > sheet_cache_max_size_) {
    target_evictions = sheet_lru_map_.size() - sheet_cache_max_size_;
  }
 
  // Evict from back of list (least recently used)
  while (!sheet_lru_list_.empty() && evicted < target_evictions) {
    int sheet_index = sheet_lru_list_.back();
    auto& sheet = gfx_sheets_[sheet_index];
 
    // Destroy texture if it exists
    if (sheet.texture()) {
      QueueTextureCommand(TextureCommandType::DESTROY, &sheet);
      LOG_DEBUG("Arena", "Evicted LRU sheet %d texture", sheet_index);
      evicted++;
      sheet_cache_stats_.evictions++;
    }
 
    // Remove from LRU tracking
    sheet_lru_map_.erase(sheet_index);
    sheet_lru_list_.pop_back();
  }
 
  sheet_cache_stats_.current_size = sheet_lru_map_.size();
 
  if (evicted > 0) {
    LOG_DEBUG("Arena", "Evicted %zu LRU sheet textures, %zu remaining", evicted,
              sheet_lru_map_.size());
  }
 
  return evicted;
}
 
void Arena::ClearSheetCache() {
  sheet_lru_list_.clear();
  sheet_lru_map_.clear();
  sheet_cache_stats_.current_size = 0;
  LOG_DEBUG("Arena", "Cleared sheet cache tracking");
}
 
}  // namespace gfx
}  // namespace yaze